Fix/sync master and release

[GauravGusain98]

Changes

• Sync master and release

[cypress]

Passing run #7787 ↗︎

0

4

0

0

0

Details:

Merge 85d24ec into 6192c3b...
Project: Employee portal	Commit: 1a0f170d83 ℹ️
Status: Passed	Duration: 00:40 💡
Started: Sep 15, 2023 6:14 AM	Ended: Sep 15, 2023 6:15 AM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[rathorevaibhav]

I think it would be easier if we make these static functions and then can directly call these like:

$reportData = RevenueReportService::getRevenueReportDataForClient($filters, $client);

[rathorevaibhav]

same feedback for this. Can be used as a static function.

[GauravGusain98]

@rathorevaibhav getting this issue when using static class

[rathorevaibhav]

@GauravGusain98 in your error screenshot, have you defined the function as static before calling it statically?

[GauravGusain98]

@GauravGusain98 in your error screenshot, have you defined the function as static before calling it statically?

If I define it as static then I am getting this error

[rathorevaibhav]

@GauravGusain98 static functions are called like this:

RevenueReportService::getRevenueGroupedByClient($filters);

// and not like
$this->getRevenueGroupedByClient($filters);