Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeline layout fix liquid sort issues #43

Open
4 tasks
evanwill opened this issue Mar 10, 2023 · 1 comment
Open
4 tasks

timeline layout fix liquid sort issues #43

evanwill opened this issue Mar 10, 2023 · 1 comment

Comments

@evanwill
Copy link
Contributor

evanwill commented Mar 10, 2023

Liquid doesn't sort numeric stuff correctly.
Add the sorting to cb_helpers plugin as a ruby function instead, like array_count_uniq, could be specific to the timeline-style layout or just sort of implement the numeric_sort that could be used anywhere.
Consider case of BC dates (negative years) and years < 1000 CE.

  • sort_numeric plugin
  • consider handling of non-number values and nils
  • rewrite timeline date parsing to avoid nils and support negative years
  • consider combining with array_count_uniq or cb_helpers or keeping all separate
@evanwill
Copy link
Contributor Author

working in branch "update-plugins".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant