private/jaume/calc scroll drift #10621
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaumePujantell
commented
Nov 28, 2024
JaumePujantell
commented
- fix typo in geometry.ts
- fix scroll drift on cell selection
added 2 commits
November 28, 2024 16:48
Signed-off-by: Jaume Pujantell <[email protected]> Change-Id: If5c3d5ef56aca862eb0af616e232d7872fa8f824
Since the center of viewedRectangle may not have integer values, there is some precision loss when converting it to a simplePoint. This causes a slight scroll to the right when selecting cells with shift+down. Signed-off-by: Jaume Pujantell <[email protected]> Change-Id: Id12fba6c08dcb9e4f0317da2c072c947e2e479fb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.