Update coolwsd.xml.in add concrete link to frame-ancestor #10551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfiguiere
reviewed
Nov 20, 2024
coolwsd.xml.in
Outdated
| @@ -184,7 +184,7 @@ | |||
| <host desc="Ditto, but as IPv4-mapped IPv6 addresses">::ffff:10\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}</host> | |||
| <host desc="Localhost access by name">localhost</host> | |||
| </lok_allow> | |||
| <content_security_policy desc="Customize the CSP header by specifying one or more policy-directive, separated by semicolons. See w3.org/TR/CSP2"></content_security_policy> | |||
| <content_security_policy desc="Customize the CSP header by specifying one or more policy-directive, separated by semicolons. See https://www.w3.org/TR/CSP2/#directive-frame-ancestors"></content_security_policy> | |||
There was a problem hiding this comment.
it allow more than just frame ancestors. Maybe it the next line should include a link to frame-ancestors CSP part of the deprecation.
|
CI failed because of lack of change-id. |
Signed-off-by: Méven Car <[email protected]> Change-Id: I95f186820737c29bb2aa177db3bf07d40188c839
hfiguiere
reviewed
Nov 20, 2024
| connect-src 'self' collabora-online-server.local; | ||
| frame-src 'self' server-to-inject-iframe-from.xyz; | ||
| connect-src 'self' server-to-inject-js-from.io | ||
| --> |
There was a problem hiding this comment.
having a frame-ancestors example would help too as it is the main use for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @hfiguiere
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay