Improve impress templates #10463
Open
Improve impress templates #10463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rash419
force-pushed
the
improve-impress-templates
branch
2 times, most recently
from
74f6d0a
to
3343b39
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Rash419
force-pushed
the
improve-impress-templates
branch
3 times, most recently
from
21de956
to
bb3c770
Compare
Rash419
commented
Nov 22, 2024
Rash419
commented
Nov 22, 2024
Rash419
force-pushed
the
improve-impress-templates
branch
3 times, most recently
from
6068c85
to
1f15134
Compare
…on/template/presnt - once we can download the templates from remote server it can be access by lokit and gets added to MasterSlides impress Signed-off-by: Rashesh <[email protected]> Change-Id: I55cb4f340f66d353594331e25debd7124f25f042
- this remote poll can download both fonts and tempalates. It also can be extended to download more asset from remote server if needed in future Signed-off-by: Rashesh <[email protected]> Change-Id: I4418319d0e1f9f3081b9dd1443719cab8ad6bbfc
Signed-off-by: Rashesh <[email protected]> Change-Id: Idc82abd26f06549b6666bfeab1fb3967cec2d303
…igPoll` Signed-off-by: Rashesh <[email protected]> Change-Id: I707486cb4f340058ba98e2cb574a81ec8317eabf
… as well - use `remote_asset_config.url` when both `remote_asset_config.url` and `remote_font_config.url` is defined. Signed-off-by: Rashesh <[email protected]> Change-Id: I3b80fea6324b4e378c4edd0ee71fd2dc7764ea14
- it was replaced by `RemoteAssetConfigPoll` Signed-off-by: Rashesh <[email protected]> Change-Id: I06490d037c9da3a90495d367c1c99a0a5aa8121c
Rash419
force-pushed
the
improve-impress-templates
branch
from
1f15134
to
41af27a
Compare
Signed-off-by: Rashesh <[email protected]> Change-Id: I3db0479faf521d1d89f59b40b7c89ea1b2485cb8
Rash419
force-pushed
the
improve-impress-templates
branch
3 times, most recently
from
2f89500
to
7d3a049
Compare
- make sure the jsdialog is visible Signed-off-by: Rashesh <[email protected]> Change-Id: Id31fe93a3ca9f4d963673935d2323edde58fd4f8
Rash419
force-pushed
the
improve-impress-templates
branch
2 times, most recently
from
4763d3d
to
6ca24b2
Compare
- it checks for "instdir/share/template/common/presnt" before mouting the "tmp/incoming/templates" on it Signed-off-by: Rashesh <[email protected]> Change-Id: Ib12723b5e90e96e9f8b914e0d15a591fcf2b9af1
Rash419
force-pushed
the
improve-impress-templates
branch
from
6ca24b2
to
7e08a70
Compare
caolanm
reviewed
Nov 26, 2024
caolanm
reviewed
Nov 26, 2024
- after core patch https://gerrit.libreoffice.org/c/core/+/177353 we create a empty 'presnt' directory Signed-off-by: Rashesh <[email protected]> Change-Id: I06d265fc90fe2454433e460d312a00589c911a2c
caolanm
reviewed
Nov 27, 2024
Signed-off-by: Rashesh <[email protected]> Change-Id: Iddb644a4ba7321ab68d8df50ec314a315a7c73df
- now to fetch presentation templates json should look like:
```
"templates": {
"presnt": [
{
"uri": "http://localhost:8080/static/impress-template/template1.otp",
"stamp": "1"
},
{
"uri": "http://localhost:8080/static/impress-template/template2.otp",
"stamp": "2"
},
{
"uri": "http://localhost:8080/static/impress-template/template3.otp",
"stamp": "3"
}
]
},
```
- this will make it easier if we want to add different types of
templates not just impress templates
Signed-off-by: Rashesh <[email protected]>
Change-Id: I55cf6e7a6c2cee2d8cbeef90d554e01b3fe18fc8
Rash419
force-pushed
the
improve-impress-templates
branch
from
ae856a6
to
f572ea5
Compare
|
Am I right that "cypress: attempt to fix "Delete Chart" test" is for an existing test failure that isn't a new problem in this pr? Maybe we should get that in a separate pr that we could merge first? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO