Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coolwsd.xml defaults vs. built-in defaults #10589

Open
timar opened this issue Nov 23, 2024 · 0 comments
Open

coolwsd.xml defaults vs. built-in defaults #10589

timar opened this issue Nov 23, 2024 · 0 comments
Labels
bug Something isn't working unconfirmed

Comments

@timar
Copy link
Member

timar commented Nov 23, 2024

Describe the Bug

In #10049 it was requested that coolwsd.xml defaults should match built-in defaults, and some progress was made. Now we have a systematic approach.
coolwsd logs non-default values from coolwsd.xml at startup.

For example:
podman run -i -t --name collabora_code -p 9980:9980 -e "extra_params=--o:ssl.enable=false --o:ssl.termination=false" docker.io/collabora/code:latest

wsd-00001-00001 2024-11-23 11:15:35.736304 +0000 [ coolwsd ] INF  Loaded config file [/etc/coolwsd/coolwsd.xml] (non-default values):
        admin_console.enable: true
        admin_console.password: <redacted>
        admin_console.username: <redacted>
        fonts_missing.handling: log
        indirection_endpoint.geolocation_setup: false
        indirection_endpoint.migration_timeout_secs:
        languagetool.enabled:
        languagetool.ssl_verification:
        logging.anonymize.anonymization_salt: <redacted>
        logging.anonymize.anonymize_user_data: false
        logging.color: false
        logging.disabled_areas: Socket,WebSocket,Admin,Pixel
        logging.file.property: /var/log/coolwsd.log
        logging.file.property[0]: /var/log/coolwsd.log
        logging.file.property[2]: timestamp
        logging.least_verbose_level_settable_from_client: fatal
        logging.most_verbose_level_settable_from_client: notice
        net.connection_timeout_secs:
        net.lok_allow.host: 192\.168\.[0-9]{1,3}\.[0-9]{1,3}
        net.lok_allow.host[10]: ::ffff:172\.3[01]\.[0-9]{1,3}\.[0-9]{1,3}
        net.lok_allow.host[11]: 10\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}
        net.lok_allow.host[12]: ::ffff:10\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}
        net.lok_allow.host[13]: localhost
        net.lok_allow.host[1]: ::ffff:192\.168\.[0-9]{1,3}\.[0-9]{1,3}
        net.lok_allow.host[2]: 127\.0\.0\.1
        net.lok_allow.host[3]: ::ffff:127\.0\.0\.1
        net.lok_allow.host[4]: ::1
        net.lok_allow.host[5]: 172\.1[6789]\.[0-9]{1,3}\.[0-9]{1,3}
        net.lok_allow.host[6]: ::ffff:172\.1[6789]\.[0-9]{1,3}\.[0-9]{1,3}
        net.lok_allow.host[7]: 172\.2[0-9]\.[0-9]{1,3}\.[0-9]{1,3}
        net.lok_allow.host[8]: ::ffff:172\.2[0-9]\.[0-9]{1,3}\.[0-9]{1,3}
        net.lok_allow.host[9]: 172\.3[01]\.[0-9]{1,3}\.[0-9]{1,3}
        net.post_allow.host: 192\.168\.[0-9]{1,3}\.[0-9]{1,3}
        net.post_allow.host[10]: ::ffff:172\.3[01]\.[0-9]{1,3}\.[0-9]{1,3}
        net.post_allow.host[11]: 10\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}
        net.post_allow.host[12]: ::ffff:10\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}
        net.post_allow.host[1]: ::ffff:192\.168\.[0-9]{1,3}\.[0-9]{1,3}
        net.post_allow.host[2]: 127\.0\.0\.1
        net.post_allow.host[3]: ::ffff:127\.0\.0\.1
        net.post_allow.host[4]: ::1
        net.post_allow.host[5]: 172\.1[6789]\.[0-9]{1,3}\.[0-9]{1,3}
        net.post_allow.host[6]: ::ffff:172\.1[6789]\.[0-9]{1,3}\.[0-9]{1,3}
        net.post_allow.host[7]: 172\.2[0-9]\.[0-9]{1,3}\.[0-9]{1,3}
        net.post_allow.host[8]: ::ffff:172\.2[0-9]\.[0-9]{1,3}\.[0-9]{1,3}
        net.post_allow.host[9]: 172\.3[01]\.[0-9]{1,3}\.[0-9]{1,3}
        net.proxy_prefix:
        per_view.min_saved_message_timeout_secs: 6
        quarantine_files.expiry_min:
        quarantine_files.limit_dir_size_mb:
        quarantine_files.max_versions_to_maintain:
        quarantine_files.path:
        remote_font_config.url:
        security.enable_macros_execution: false
        security.enable_websocket_urp: false
        security.macro_security_level: 1
        ssl.enable: false
        ssl.hpkp: 1000
        ssl.hpkp.max_age: 1000
        ssl.hpkp.pins:
        ssl.hpkp.pins.pin:
        ssl.hpkp.report_uri:
        storage.filesystem:
        storage.ssl: true
        storage.ssl.as_scheme: true
        storage.ssl.enable:
        storage.wopi: 0900
        storage.wopi.alias_groups:
        storage.wopi.is_legacy_server:
        storage.wopi.locking: 900
        trace.filter:
        trace.filter.message:
        trace.outgoing: false
        trace.outgoing.record: false
        trace.path:
        trace_event.path: /var/log/coolwsd.trace.json
        wasm.enable:
        wasm.force:
        watermark.opacity:
        watermark.text:
  • Here only the ssl.enable: false is interesting, because we changed that one in the command line.
  • The empty values may be empty in coolwsd.xml but have a default in the code so that default prevails.
  • When there is a value, probably it's defined in coolwsd.xml, but not in the code. This is what coolwsd.xml defaults do not match built-in defaults #10049 was about originally.
  • Ideally we should only see what is relevant, in this list.

(I just dumped it so I do not forget, nothing is urgent about it. It was CODE 24.04.10.1.)
CC @Ashod

@timar timar added bug Something isn't working unconfirmed labels Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unconfirmed
Projects
Status: No status
Development

No branches or pull requests

1 participant