Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Line wrap limit in README.md? #51

Open
donquixote opened this issue Nov 7, 2024 · 2 comments
Open

Question: Line wrap limit in README.md? #51

donquixote opened this issue Nov 7, 2024 · 2 comments

Comments

@donquixote
Copy link
Collaborator

Hello @hfiguiere,

I saw the commit 0a1f1dd which reformats the README.md, adding line breaks.
Do you have a specific limit in mind?
In Drupal core a typical character limit per line would be 80 chars.
In the reformat commit, I see line breaks were inserted at somewhere between 70 chars and 80 chars, but it was not consistent.

Should we agree on 80 chars to align with Drupal core?

Personally I would be ok to drop the character limit.
However, I am not sure if this will be checked by phpcs with Drupal rules.

@hfiguiere
Copy link
Collaborator

I just rewrapped in Emacs to be consistent with the rest.

@donquixote
Copy link
Collaborator Author

I just rewrapped in Emacs to be consistent with the rest.

Ok but do you have a specific limit configured in emacs? And is that changeable?
Ideally, everybody working on this project should use the same line limit, and ideally it should be the same as what the implicit or explicit convention in Drupal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants