You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I saw the commit 0a1f1dd which reformats the README.md, adding line breaks.
Do you have a specific limit in mind?
In Drupal core a typical character limit per line would be 80 chars.
In the reformat commit, I see line breaks were inserted at somewhere between 70 chars and 80 chars, but it was not consistent.
Should we agree on 80 chars to align with Drupal core?
Personally I would be ok to drop the character limit.
However, I am not sure if this will be checked by phpcs with Drupal rules.
The text was updated successfully, but these errors were encountered:
I just rewrapped in Emacs to be consistent with the rest.
Ok but do you have a specific limit configured in emacs? And is that changeable?
Ideally, everybody working on this project should use the same line limit, and ideally it should be the same as what the implicit or explicit convention in Drupal.
Hello @hfiguiere,
I saw the commit 0a1f1dd which reformats the README.md, adding line breaks.
Do you have a specific limit in mind?
In Drupal core a typical character limit per line would be 80 chars.
In the reformat commit, I see line breaks were inserted at somewhere between 70 chars and 80 chars, but it was not consistent.
Should we agree on 80 chars to align with Drupal core?
Personally I would be ok to drop the character limit.
However, I am not sure if this will be checked by phpcs with Drupal rules.
The text was updated successfully, but these errors were encountered: