From 3562f1ee6c0a860b8fc7af09f8df9d71e6bdad3a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Yulia=20=C4=8Cech?= <6585477+yuliacech@users.noreply.github.com> Date: Fri, 26 Jan 2024 17:18:52 +0100 Subject: [PATCH] [Index Management] Update the columns width in the index templates and component templates tables (#175337) ## Summary Fixes https://github.com/elastic/kibana/issues/174946 This PR tries to improve the readability of the index templates and component templates lists by setting the columns with text information to be wider and to not truncate the text. The badges in the name columns are also set to `inline` which makes the word breaking in the columns better imho. See screenshots with before and after on a smaller screen (just before the tables switch from rows to a mobile view). ### Screenshots #### Index templates Before Screenshot 2024-01-24 at 18 41 15 After Screenshot 2024-01-24 at 18 40 37 #### Component templates Before Screenshot 2024-01-24 at 18 41 23 After Screenshot 2024-01-24 at 18 40 47 ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --- .../component_template_list/table.tsx | 12 ++++++++---- .../template_table/template_table.tsx | 14 ++++++++------ 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/x-pack/plugins/index_management/public/application/components/component_templates/component_template_list/table.tsx b/x-pack/plugins/index_management/public/application/components/component_templates/component_template_list/table.tsx index 83bcc171a4873..b8b371f6e4e01 100644 --- a/x-pack/plugins/index_management/public/application/components/component_templates/component_template_list/table.tsx +++ b/x-pack/plugins/index_management/public/application/components/component_templates/component_template_list/table.tsx @@ -46,6 +46,7 @@ export const ComponentTable: FunctionComponent = ({ const [selection, setSelection] = useState([]); const tableProps: EuiInMemoryTableProps = { + tableLayout: 'auto', itemId: 'name', isSelectable: true, 'data-test-subj': 'componentTemplatesTable', @@ -154,9 +155,9 @@ export const ComponentTable: FunctionComponent = ({ defaultMessage: 'Name', }), sortable: true, - width: '20%', + width: '45%', render: (name: string, item: ComponentTemplateListItem) => ( - <> + = ({ {item.isManaged && ( <> -   + {' '} {i18n.translate('xpack.idxMgmt.componentTemplatesList.table.managedBadgeLabel', { defaultMessage: 'Managed', @@ -179,7 +180,7 @@ export const ComponentTable: FunctionComponent = ({ )} - + ), }, { @@ -211,6 +212,7 @@ export const ComponentTable: FunctionComponent = ({ defaultMessage: 'Mappings', }), truncateText: true, + align: 'center', sortable: true, render: (hasMappings: boolean) => (hasMappings ? : null), }, @@ -220,6 +222,7 @@ export const ComponentTable: FunctionComponent = ({ defaultMessage: 'Settings', }), truncateText: true, + align: 'center', sortable: true, render: (hasSettings: boolean) => (hasSettings ? : null), }, @@ -229,6 +232,7 @@ export const ComponentTable: FunctionComponent = ({ defaultMessage: 'Aliases', }), truncateText: true, + align: 'center', sortable: true, render: (hasAliases: boolean) => (hasAliases ? : null), }, diff --git a/x-pack/plugins/index_management/public/application/sections/home/template_list/template_table/template_table.tsx b/x-pack/plugins/index_management/public/application/sections/home/template_list/template_table/template_table.tsx index 8a6ed8ac079a2..c441f02fc4062 100644 --- a/x-pack/plugins/index_management/public/application/sections/home/template_list/template_table/template_table.tsx +++ b/x-pack/plugins/index_management/public/application/sections/home/template_list/template_table/template_table.tsx @@ -48,11 +48,11 @@ export const TemplateTable: React.FunctionComponent = ({ name: i18n.translate('xpack.idxMgmt.templateList.table.nameColumnTitle', { defaultMessage: 'Name', }), - truncateText: true, sortable: true, + width: '30%', render: (name: TemplateListItem['name'], item: TemplateListItem) => { return ( - <> + uiMetricService.trackMetric(METRIC_TYPE.CLICK, UIM_TEMPLATE_SHOW_DETAILS_CLICK) @@ -60,10 +60,9 @@ export const TemplateTable: React.FunctionComponent = ({ data-test-subj="templateDetailsLink" > {name} - -   + {' '} - + ); }, }, @@ -72,8 +71,8 @@ export const TemplateTable: React.FunctionComponent = ({ name: i18n.translate('xpack.idxMgmt.templateList.table.indexPatternsColumnTitle', { defaultMessage: 'Index patterns', }), - truncateText: true, sortable: true, + width: '20%', render: (indexPatterns: string[]) => {indexPatterns.join(', ')}, }, { @@ -83,12 +82,15 @@ export const TemplateTable: React.FunctionComponent = ({ }), truncateText: true, sortable: true, + width: '20%', render: (composedOf: string[] = []) => {composedOf.join(', ')}, }, { name: i18n.translate('xpack.idxMgmt.templateList.table.dataStreamColumnTitle', { defaultMessage: 'Data stream', }), + width: '90px', + align: 'center', truncateText: true, render: (template: TemplateListItem) => template._kbnMeta.hasDatastream ? : null,