Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Storybook during deploy #902

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevinweber
Copy link
Contributor

https://mentors.codingcoach.io/sb/ is supposed to show the Storybook according to the README. This change causes Storybook to be built during the deploy. I verified that this works by going to the gh-pages version of my forked project: https://kevinweber.github.io/find-a-mentor/sb/

@vercel
Copy link

vercel bot commented Mar 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

find-a-mentor – ./

🔍 Inspect: https://vercel.com/adminvercel-codingcoach/find-a-mentor/AorrExtfr4xqyirKLBPaJYw5PMhY
✅ Preview: Failed

[Deployment for 79e50c6 failed]

@vercel
Copy link

vercel bot commented Mar 8, 2022

Deployment failed with the following error:

The most recent charge for your active payment method has failed. Please update it here: https://vercel.com/teams/coding-coach/settings/billing.

Copy link
Member

@moshfeu moshfeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks!
We are using netlify (for now) but let's see if it works too.

@moshfeu
Copy link
Member

moshfeu commented Mar 27, 2022

With your permission, let's keep it until we will move to nextjs (#876) very soon I believe ❤️

@kevinweber
Copy link
Contributor Author

Of course! Thanks for the heads-up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants