Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo list exercise has people create not amazing HTML #1289

Open
illicitonion opened this issue Jan 7, 2025 · 0 comments
Open

Todo list exercise has people create not amazing HTML #1289

illicitonion opened this issue Jan 7, 2025 · 0 comments

Comments

@illicitonion
Copy link
Member

In https://github.com/CodeYourFuture/Module-Data-Groups/blob/main/Sprint-3/todo-list/README.md#instructions we instruct people to create buttons using this HTML:

<i class="fa fa-check" aria-hidden="true"></i>
<i class="fa fa-trash" aria-hidden="true"></i>

This seems not amazing - <i> is not a very semantic tag for a button, and setting aria-hidden I believe means that screen-readers will not expose to their users the ability to mark to do items as done or deleted?

These feel like bad habits to be teaching people...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant