Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

["model"] Refactor calculations to avoid repeated methodological questions #277

Closed
PhilMiller opened this issue Mar 27, 2020 · 3 comments
Closed
Assignees
Labels
models Correct/improve the underlying models

Comments

@PhilMiller
Copy link
Collaborator

Summary

People keep asking about why/how the new infections, admissions, and census are calculated. We have every reason to believe the code is correct but it's hard for new readers of the code (including myself, when I started, and still) to follow. We can revise it without changing the output to clarify what it's doing.

Additional details

Suggested fix

Express the computation exactly as you would the derivation or an explanation - cf 'literate code'.

@PhilMiller PhilMiller added the models Correct/improve the underlying models label Mar 27, 2020
@PhilMiller PhilMiller self-assigned this Mar 27, 2020
@PhilMiller
Copy link
Collaborator Author

@cjbayesian @quinn-dougherty

Is the current dispositions_df useful in itself, possibly for some future feature, or is it purely an intermediate for the calculation of admissions and census?

@PhilMiller
Copy link
Collaborator Author

Incidentally, this refactoring also makes #206 into a one-line fix: change the day 0 value of new_infections from 0.0 to i

@PhilMiller
Copy link
Collaborator Author

E.g. #222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
models Correct/improve the underlying models
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants