Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implementation of Central CMS #887

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: Implementation of Central CMS #887

wants to merge 10 commits into from

Conversation

m453h
Copy link
Contributor

@m453h m453h commented Sep 11, 2024

Description

This PR introduces the Central CMS application, built on Payload 3.0, designed to manage content across multiple full-stack applications.

Fixes #885

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Screenshot 2024-09-11 at 17 39 42 Screenshot 2024-09-11 at 17 40 07

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@m453h m453h added the enhancement New feature or request label Sep 11, 2024
@m453h m453h self-assigned this Sep 11, 2024
@m453h m453h marked this pull request as ready for review September 12, 2024 10:32
@m453h m453h requested a review from a team September 12, 2024 10:33
koechkevin
koechkevin reviewed Sep 12, 2024
View reviewed changes
Copy link
Contributor

@koechkevin koechkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m453h files changed too many to review at 1 go. Couldn't we have started with 1 app (say roboshield in a separate PR) then open another PR for codeforafrica against the first PR?

I am also open to other suggestions.

apps/centralcms/README.md Outdated Show resolved Hide resolved
apps/centralcms/.gitignore Outdated Show resolved Hide resolved
@m453h
Copy link
Contributor Author

m453h commented Sep 12, 2024

@m453h files changed too many to review at 1 go. Couldn't we have started with 1 app (say roboshield in a separate PR) then open another PR for codeforafrica against the first PR?

I am also open to other suggestions.

I totally feel your pain 😢. I kept the two apps to demonstrate how the multi-app setup would work. I actually reduced the scope by excluding some CivicSignal collectoins/blocks because it was becoming too large, you can first confirm if the functionality works as intended locally before we decide to remove them (if necessary)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koechkevin koechkevin koechkevin left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@m453h m453h

Labels
enhancement New feature or request
Projects
COMMONS
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Payload 3.0 Central CMS implementation
2 participants
@m453h @koechkevin