From 2d5311dcd4bd31d4f746eff933b407e3b7251955 Mon Sep 17 00:00:00 2001
From: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Date: Wed, 17 Jul 2024 14:55:01 +0300
Subject: [PATCH] Review fix

---
 .../src/components/HURUmap/KeyMetric/index.js |  2 +-
 .../src/components/HURUmap/KeyMetric/index.js |  2 +-
 packages/hurumap-core/package.json            |  3 +--
 packages/hurumap-next/CHANGELOG.md            | 20 +------------------
 packages/hurumap-next/package.json            |  2 --
 packages/hurumap-next/src/Source/Source.js    |  4 ++--
 pnpm-lock.yaml                                |  6 ------
 7 files changed, 6 insertions(+), 33 deletions(-)

diff --git a/apps/climatemappedafrica/src/components/HURUmap/KeyMetric/index.js b/apps/climatemappedafrica/src/components/HURUmap/KeyMetric/index.js
index 49d6a2712..6e39bbc24 100644
--- a/apps/climatemappedafrica/src/components/HURUmap/KeyMetric/index.js
+++ b/apps/climatemappedafrica/src/components/HURUmap/KeyMetric/index.js
@@ -69,7 +69,7 @@ function KeyMetric({
       <Source
         href={url}
         sx={(theme) => ({
-          margin: `${theme.typography.pxToRem(20)} 0`,
+          marginTop: theme.typography.pxToRem(10),
         })}
       >
         {source}
diff --git a/apps/pesayetu/src/components/HURUmap/KeyMetric/index.js b/apps/pesayetu/src/components/HURUmap/KeyMetric/index.js
index 49d6a2712..9816936a4 100644
--- a/apps/pesayetu/src/components/HURUmap/KeyMetric/index.js
+++ b/apps/pesayetu/src/components/HURUmap/KeyMetric/index.js
@@ -69,7 +69,7 @@ function KeyMetric({
       <Source
         href={url}
         sx={(theme) => ({
-          margin: `${theme.typography.pxToRem(20)} 0`,
+          marginTop: `${theme.typography.pxToRem(20)} 0`,
         })}
       >
         {source}
diff --git a/packages/hurumap-core/package.json b/packages/hurumap-core/package.json
index 6cd44cc5c..2ff1cc6db 100644
--- a/packages/hurumap-core/package.json
+++ b/packages/hurumap-core/package.json
@@ -67,7 +67,6 @@
     "react-leaflet": "^4.2.1"
   },
   "dependencies": {
-    "prop-types": "^15.8.1",
-    "@commons-ui/next": "workspace:*"
+    "prop-types": "^15.8.1"
   }
 }
diff --git a/packages/hurumap-next/CHANGELOG.md b/packages/hurumap-next/CHANGELOG.md
index fba4c02e7..051cf71eb 100644
--- a/packages/hurumap-next/CHANGELOG.md
+++ b/packages/hurumap-next/CHANGELOG.md
@@ -1,19 +1 @@
-# @commons-ui/next
-
-## 2.0.1
-
-### Patch Changes
-
-- [#247](https://github.com/CodeForAfrica/ui/pull/247) [`2a01454`](https://github.com/CodeForAfrica/ui/commit/2a014544fa84b7385cfa9496596699fdd1b3a0ba) Thanks [@kilemensi](https://github.com/kilemensi)! - Fixes playwright e2e testing + standardises SEO titles
-
-- Updated dependencies [[`2a01454`](https://github.com/CodeForAfrica/ui/commit/2a014544fa84b7385cfa9496596699fdd1b3a0ba)]:
-  - @commons-ui/core@2.0.1
-
-## 2.0.0
-
-### Patch Changes
-
-- [#241](https://github.com/CodeForAfrica/ui/pull/241) [`f792694`](https://github.com/CodeForAfrica/ui/commit/f7926944fb505adaa8905dc8aeba04913f56ea85) Thanks [@kilemensi](https://github.com/kilemensi)! - Improved RichTypography to better handle color and relative links
-
-- Updated dependencies [[`f792694`](https://github.com/CodeForAfrica/ui/commit/f7926944fb505adaa8905dc8aeba04913f56ea85)]:
-  - @commons-ui/core@2.0.0
+# @hurumap/next
diff --git a/packages/hurumap-next/package.json b/packages/hurumap-next/package.json
index de2a2b9d3..3d2f6055b 100644
--- a/packages/hurumap-next/package.json
+++ b/packages/hurumap-next/package.json
@@ -53,14 +53,12 @@
     "@babel/core": "^7.22.9",
     "@commons-ui/core": "workspace:*",
     "@mui/material": "^5.14.0",
-    "clsx": "^2.0.0",
     "next": "~13.4.11",
     "prop-types": "^15.8.1",
     "react": "^18.2.0",
     "react-dom": "^18.2.0"
   },
   "dependencies": {
-    "clsx": "^2.1.1",
     "@commons-ui/next": "workspace:*"
   }
 }
diff --git a/packages/hurumap-next/src/Source/Source.js b/packages/hurumap-next/src/Source/Source.js
index b43e812bf..b4f4b7c0d 100644
--- a/packages/hurumap-next/src/Source/Source.js
+++ b/packages/hurumap-next/src/Source/Source.js
@@ -4,11 +4,11 @@ import React from "react";
 
 const Source = React.forwardRef(function Source(
   {
+    LinkProps,
+    TitleTypographyProps,
     children,
     href,
     title = "Source",
-    TitleTypographyProps,
-    LinkProps,
     ...props
   },
   ref,
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 1a9872aca..77dfb1332 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -1769,9 +1769,6 @@ importers:
 
   packages/hurumap-core:
     dependencies:
-      '@commons-ui/next':
-        specifier: workspace:*
-        version: link:../commons-ui-next
       prop-types:
         specifier: ^15.8.1
         version: 15.8.1
@@ -1851,9 +1848,6 @@ importers:
       '@commons-ui/next':
         specifier: workspace:*
         version: link:../commons-ui-next
-      clsx:
-        specifier: ^2.1.1
-        version: 2.1.1
     devDependencies:
       '@babel/core':
         specifier: ^7.24.8