From 835b7c6e43181396ee2ad9178e52defb291d0a98 Mon Sep 17 00:00:00 2001 From: Clemence Kyara Date: Fri, 6 Sep 2024 12:43:57 +0300 Subject: [PATCH 01/11] Remove page router specific features from Link --- packages/commons-ui-next/src/Link/Link.js | 46 ++--------------------- 1 file changed, 3 insertions(+), 43 deletions(-) diff --git a/packages/commons-ui-next/src/Link/Link.js b/packages/commons-ui-next/src/Link/Link.js index 5356e339e..684b6e9b9 100644 --- a/packages/commons-ui-next/src/Link/Link.js +++ b/packages/commons-ui-next/src/Link/Link.js @@ -1,11 +1,8 @@ -/* eslint-env browser */ import MuiLink from "@mui/material/Link"; import { styled } from "@mui/material/styles"; -import clsx from "clsx"; import NextLink from "next/link"; -import { useRouter } from "next/router"; import PropTypes from "prop-types"; -import React, { useEffect, useState } from "react"; +import React from "react"; import isExternalUrl from "@/commons-ui/next/utils/isExternalUrl"; @@ -57,19 +54,13 @@ NextLinkComposed.propTypes = { to: PropTypes.oneOfType([PropTypes.object, PropTypes.string]).isRequired, }; -function checkIfPathsMatch(linkPath, currentPath) { - return linkPath === currentPath; -} - // A styled version of the Next.js Link component: // https://nextjs.org/docs/api-reference/next/link const Link = React.forwardRef(function Link(props, ref) { const { - activeClassName = "active", as, - className: classNameProp, + className, href, - isActive: isActiveProp, legacyBehavior, linkAs: linkAsProp, locale, @@ -82,37 +73,7 @@ const Link = React.forwardRef(function Link(props, ref) { ...other } = props; - const { asPath, isReady } = useRouter(); - const [className, setClassName] = useState(classNameProp); - const linkAs = linkAsProp || as; - const isActive = isActiveProp || checkIfPathsMatch; - - useEffect(() => { - if (isReady) { - const linkPathname = new URL(linkAs || href, window.location.href) - .pathname; - const activePathname = new URL(asPath, window.location.href).pathname; - const newClassName = clsx(classNameProp, { - [activeClassName]: isActive(linkPathname, activePathname), - }); - - if (newClassName !== className) { - setClassName(newClassName); - } - } - }, [ - activeClassName, - asPath, - className, - classNameProp, - href, - isActive, - isReady, - linkAs, - ]); - const isExternal = isExternalUrl(href); - if (isExternal) { const externalLinkProps = { href, @@ -126,6 +87,7 @@ const Link = React.forwardRef(function Link(props, ref) { return ; } + const linkAs = linkAsProp || as; const nextjsProps = { to: href, linkAs, @@ -159,11 +121,9 @@ const Link = React.forwardRef(function Link(props, ref) { }); Link.propTypes = { - activeClassName: PropTypes.string, as: PropTypes.oneOfType([PropTypes.object, PropTypes.string]), className: PropTypes.string, href: PropTypes.string, - isActive: PropTypes.func, legacyBehavior: PropTypes.bool, linkAs: PropTypes.oneOfType([PropTypes.object, PropTypes.string]), locale: PropTypes.string, From 59620cb15478cb9106748ae321cf581bcc75a599 Mon Sep 17 00:00:00 2001 From: Clemence Kyara Date: Fri, 6 Sep 2024 12:49:55 +0300 Subject: [PATCH 02/11] Add a Link specifically for Pages Router --- .../src/Link/PageRouterLink.js | 87 +++++++++++++++++++ 1 file changed, 87 insertions(+) create mode 100644 packages/commons-ui-next/src/Link/PageRouterLink.js diff --git a/packages/commons-ui-next/src/Link/PageRouterLink.js b/packages/commons-ui-next/src/Link/PageRouterLink.js new file mode 100644 index 000000000..c9238566a --- /dev/null +++ b/packages/commons-ui-next/src/Link/PageRouterLink.js @@ -0,0 +1,87 @@ +/* eslint-env browser */ +import clsx from "clsx"; +import { useRouter } from "next/router"; +import PropTypes from "prop-types"; +import React, { useEffect, useState } from "react"; + +import Link from "./Link"; + +function checkIfPathsMatch(linkPath, currentPath) { + return linkPath === currentPath; +} + +// A styled version of the Next.js Link component: +// https://nextjs.org/docs/api-reference/next/link +const PageRouterLink = React.forwardRef( + function PageRouterLinkLink(props, ref) { + const { + activeClassName, + as, + className: classNameProp, + href, + isActive: isActiveProp, + linkAs: linkAsProp, + locale, + scroll, + ...other + } = props; + + const { asPath, isReady } = useRouter(); + const [className, setClassName] = useState(classNameProp); + const linkAs = linkAsProp || as; + const isActive = isActiveProp || checkIfPathsMatch; + + useEffect(() => { + if (isReady) { + const linkPathname = new URL(linkAs || href, window.location.href) + .pathname; + const activePathname = new URL(asPath, window.location.href).pathname; + const newClassName = clsx(classNameProp, { + [activeClassName]: isActive(linkPathname, activePathname), + }); + + if (newClassName !== className) { + setClassName(newClassName); + } + } + }, [ + activeClassName, + asPath, + className, + classNameProp, + href, + isActive, + isReady, + linkAs, + ]); + + return ( + + ); + }, +); + +PageRouterLink.propTypes = { + activeClassName: PropTypes.string, + as: PropTypes.oneOfType([PropTypes.object, PropTypes.string]), + className: PropTypes.string, + href: PropTypes.string, + isActive: PropTypes.func, + legacyBehavior: PropTypes.bool, + linkAs: PropTypes.oneOfType([PropTypes.object, PropTypes.string]), + locale: PropTypes.string, + noLinkStyle: PropTypes.bool, + prefetch: PropTypes.bool, + replace: PropTypes.bool, + role: PropTypes.string, + scroll: PropTypes.bool, + shallow: PropTypes.bool, +}; + +export default PageRouterLink; From b7e97b3456bcaed7e130079de20d63de7fd048b0 Mon Sep 17 00:00:00 2001 From: Clemence Kyara Date: Fri, 6 Sep 2024 12:51:34 +0300 Subject: [PATCH 03/11] Rename to PagesRouterLink (match router name) --- .../src/Link/{PageRouterLink.js => PagesRouterLink.js} | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) rename packages/commons-ui-next/src/Link/{PageRouterLink.js => PagesRouterLink.js} (93%) diff --git a/packages/commons-ui-next/src/Link/PageRouterLink.js b/packages/commons-ui-next/src/Link/PagesRouterLink.js similarity index 93% rename from packages/commons-ui-next/src/Link/PageRouterLink.js rename to packages/commons-ui-next/src/Link/PagesRouterLink.js index c9238566a..e8b37e56e 100644 --- a/packages/commons-ui-next/src/Link/PageRouterLink.js +++ b/packages/commons-ui-next/src/Link/PagesRouterLink.js @@ -12,8 +12,8 @@ function checkIfPathsMatch(linkPath, currentPath) { // A styled version of the Next.js Link component: // https://nextjs.org/docs/api-reference/next/link -const PageRouterLink = React.forwardRef( - function PageRouterLinkLink(props, ref) { +const PagesRouterLink = React.forwardRef( + function PagesRouterLinkLink(props, ref) { const { activeClassName, as, @@ -67,7 +67,7 @@ const PageRouterLink = React.forwardRef( }, ); -PageRouterLink.propTypes = { +PagesRouterLink.propTypes = { activeClassName: PropTypes.string, as: PropTypes.oneOfType([PropTypes.object, PropTypes.string]), className: PropTypes.string, @@ -84,4 +84,4 @@ PageRouterLink.propTypes = { shallow: PropTypes.bool, }; -export default PageRouterLink; +export default PagesRouterLink; From baf5df8e32ade70373f84243e4c8216de68faa69 Mon Sep 17 00:00:00 2001 From: Clemence Kyara Date: Fri, 6 Sep 2024 14:10:03 +0300 Subject: [PATCH 04/11] Rename to avoid collision when exported --- .../src/Link/{Link.js => StyledLink.js} | 36 ++++++++----------- .../Link/{Link.snap.js => StyledLink.snap.js} | 4 +-- .../Link/{Link.test.js => StyledLink.test.js} | 6 ++-- 3 files changed, 20 insertions(+), 26 deletions(-) rename packages/commons-ui-next/src/Link/{Link.js => StyledLink.js} (79%) rename packages/commons-ui-next/src/Link/{Link.snap.js => StyledLink.snap.js} (57%) rename packages/commons-ui-next/src/Link/{Link.test.js => StyledLink.test.js} (53%) diff --git a/packages/commons-ui-next/src/Link/Link.js b/packages/commons-ui-next/src/Link/StyledLink.js similarity index 79% rename from packages/commons-ui-next/src/Link/Link.js rename to packages/commons-ui-next/src/Link/StyledLink.js index 684b6e9b9..956af28ea 100644 --- a/packages/commons-ui-next/src/Link/Link.js +++ b/packages/commons-ui-next/src/Link/StyledLink.js @@ -9,7 +9,7 @@ import isExternalUrl from "@/commons-ui/next/utils/isExternalUrl"; // Add support for the sx prop for consistency with the other branches. const Anchor = styled("a")({}); -export const NextLinkComposed = React.forwardRef( +const NextLinkComposed = React.forwardRef( function NextLinkComposed(props, ref) { const { linkAs, @@ -56,7 +56,7 @@ NextLinkComposed.propTypes = { // A styled version of the Next.js Link component: // https://nextjs.org/docs/api-reference/next/link -const Link = React.forwardRef(function Link(props, ref) { +const StyledLink = React.forwardRef(function Link(props, ref) { const { as, className, @@ -73,7 +73,9 @@ const Link = React.forwardRef(function Link(props, ref) { ...other } = props; - const isExternal = isExternalUrl(href); + // https://nextjs.org/docs/app/api-reference/components/link#href-required + const url = typeof href === "string" ? href : href.pathname; + const isExternal = isExternalUrl(url); if (isExternal) { const externalLinkProps = { href, @@ -81,10 +83,10 @@ const Link = React.forwardRef(function Link(props, ref) { target: "_blank", ...other, }; - if (noLinkStyle) { - return ; - } - return ; + const LinkComponent = noLinkStyle ? Anchor : MuiLink; + return ( + + ); } const linkAs = linkAsProp || as; @@ -99,28 +101,20 @@ const Link = React.forwardRef(function Link(props, ref) { locale, }; - if (noLinkStyle) { - return ( - - ); - } + const LinkComponent = noLinkStyle ? NextLinkComposed : MuiLink; + const component = noLinkStyle ? undefined : NextLinkComposed; return ( - ); }); -Link.propTypes = { +StyledLink.propTypes = { as: PropTypes.oneOfType([PropTypes.object, PropTypes.string]), className: PropTypes.string, href: PropTypes.string, @@ -135,4 +129,4 @@ Link.propTypes = { shallow: PropTypes.bool, }; -export default Link; +export default StyledLink; diff --git a/packages/commons-ui-next/src/Link/Link.snap.js b/packages/commons-ui-next/src/Link/StyledLink.snap.js similarity index 57% rename from packages/commons-ui-next/src/Link/Link.snap.js rename to packages/commons-ui-next/src/Link/StyledLink.snap.js index 87676a140..db0e8ddea 100644 --- a/packages/commons-ui-next/src/Link/Link.snap.js +++ b/packages/commons-ui-next/src/Link/StyledLink.snap.js @@ -1,9 +1,9 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP -exports[` renders unchanged 1`] = ` +exports[` renders unchanged 1`] = `
Home diff --git a/packages/commons-ui-next/src/Link/Link.test.js b/packages/commons-ui-next/src/Link/StyledLink.test.js similarity index 53% rename from packages/commons-ui-next/src/Link/Link.test.js rename to packages/commons-ui-next/src/Link/StyledLink.test.js index 4ef10c59d..0d9c03e0a 100644 --- a/packages/commons-ui-next/src/Link/Link.test.js +++ b/packages/commons-ui-next/src/Link/StyledLink.test.js @@ -1,11 +1,11 @@ import { render } from "@commons-ui/testing-library"; import React from "react"; -import Link from "./Link"; +import StyledLink from "./StyledLink"; -describe("", () => { +describe("", () => { it("renders unchanged", () => { - const { container } = render(Home); + const { container } = render(Home); expect(container).toMatchSnapshot(); }); }); From 52d776212161baeadeabd3e4626dc8f13ff0f3fa Mon Sep 17 00:00:00 2001 From: Clemence Kyara Date: Fri, 6 Sep 2024 14:10:43 +0300 Subject: [PATCH 05/11] Add tests and export both StyledLink and PagesRouterLink --- .../src/Link/PagesRouterLink.js | 24 ++++++++++--------- .../src/Link/PagesRouterLink.snap.js | 12 ++++++++++ .../src/Link/PagesRouterLink.test.js | 13 ++++++++++ packages/commons-ui-next/src/Link/index.js | 8 +++++-- 4 files changed, 44 insertions(+), 13 deletions(-) create mode 100644 packages/commons-ui-next/src/Link/PagesRouterLink.snap.js create mode 100644 packages/commons-ui-next/src/Link/PagesRouterLink.test.js diff --git a/packages/commons-ui-next/src/Link/PagesRouterLink.js b/packages/commons-ui-next/src/Link/PagesRouterLink.js index e8b37e56e..d1a214b3d 100644 --- a/packages/commons-ui-next/src/Link/PagesRouterLink.js +++ b/packages/commons-ui-next/src/Link/PagesRouterLink.js @@ -4,14 +4,14 @@ import { useRouter } from "next/router"; import PropTypes from "prop-types"; import React, { useEffect, useState } from "react"; -import Link from "./Link"; +import StyledLink from "./StyledLink"; + +import isExternalUrl from "@/commons-ui/next/utils/isExternalUrl"; function checkIfPathsMatch(linkPath, currentPath) { return linkPath === currentPath; } -// A styled version of the Next.js Link component: -// https://nextjs.org/docs/api-reference/next/link const PagesRouterLink = React.forwardRef( function PagesRouterLinkLink(props, ref) { const { @@ -21,25 +21,25 @@ const PagesRouterLink = React.forwardRef( href, isActive: isActiveProp, linkAs: linkAsProp, - locale, - scroll, ...other } = props; const { asPath, isReady } = useRouter(); const [className, setClassName] = useState(classNameProp); - const linkAs = linkAsProp || as; const isActive = isActiveProp || checkIfPathsMatch; + const isInternalLink = !isExternalUrl( + typeof href === "string" ? href : href.pathname, + ); + const linkAs = linkAsProp || as; useEffect(() => { - if (isReady) { + if (isReady && isInternalLink) { const linkPathname = new URL(linkAs || href, window.location.href) .pathname; - const activePathname = new URL(asPath, window.location.href).pathname; + const currentPathname = new URL(asPath, window.location.href).pathname; const newClassName = clsx(classNameProp, { - [activeClassName]: isActive(linkPathname, activePathname), + [activeClassName]: isActive(linkPathname, currentPathname), }); - if (newClassName !== className) { setClassName(newClassName); } @@ -51,15 +51,17 @@ const PagesRouterLink = React.forwardRef( classNameProp, href, isActive, + isInternalLink, isReady, linkAs, ]); return ( - diff --git a/packages/commons-ui-next/src/Link/PagesRouterLink.snap.js b/packages/commons-ui-next/src/Link/PagesRouterLink.snap.js new file mode 100644 index 000000000..e8b50d2bb --- /dev/null +++ b/packages/commons-ui-next/src/Link/PagesRouterLink.snap.js @@ -0,0 +1,12 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[` renders unchanged 1`] = ` + +`; diff --git a/packages/commons-ui-next/src/Link/PagesRouterLink.test.js b/packages/commons-ui-next/src/Link/PagesRouterLink.test.js new file mode 100644 index 000000000..cef5f5ac7 --- /dev/null +++ b/packages/commons-ui-next/src/Link/PagesRouterLink.test.js @@ -0,0 +1,13 @@ +import { render } from "@commons-ui/testing-library"; +import React from "react"; + +import PagesRouterLink from "./PagesRouterLink"; + +describe("", () => { + it("renders unchanged", () => { + const { container } = render( + Home, + ); + expect(container).toMatchSnapshot(); + }); +}); diff --git a/packages/commons-ui-next/src/Link/index.js b/packages/commons-ui-next/src/Link/index.js index 6d59fd0b2..f0bdce76f 100644 --- a/packages/commons-ui-next/src/Link/index.js +++ b/packages/commons-ui-next/src/Link/index.js @@ -1,3 +1,7 @@ -import Link from "./Link"; +import PagesRouterLink from "./PagesRouterLink"; +import StyledLink from "./StyledLink"; -export default Link; +export { StyledLink, PagesRouterLink }; + +// To be backward-compatible, set default Link to PagesRouterLink +export default PagesRouterLink; From db77fcb55600bf7ca8392e84b48918d9248e1726 Mon Sep 17 00:00:00 2001 From: Clemence Kyara Date: Fri, 6 Sep 2024 14:11:22 +0300 Subject: [PATCH 06/11] Export StyledLink and PagesRouterLink from package --- packages/commons-ui-next/src/index.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/commons-ui-next/src/index.js b/packages/commons-ui-next/src/index.js index 4b21cb922..548f9c705 100644 --- a/packages/commons-ui-next/src/index.js +++ b/packages/commons-ui-next/src/index.js @@ -1,5 +1,6 @@ -/* eslint-disable import/prefer-default-export */ - export { default as Figure } from "./Figure"; + export { default as Link } from "./Link"; +export * from "./Link"; + export { default as RichTypography } from "./RichTypography"; From 01cff17456b728e2ec8c5d866a1ce5542ede6c17 Mon Sep 17 00:00:00 2001 From: Clemence Kyara Date: Fri, 6 Sep 2024 14:12:04 +0300 Subject: [PATCH 07/11] Use StyledLink in engineeringblog --- apps/engineeringblog/components/Logo/Logo.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/apps/engineeringblog/components/Logo/Logo.tsx b/apps/engineeringblog/components/Logo/Logo.tsx index 2f44cdc06..3e0786617 100644 --- a/apps/engineeringblog/components/Logo/Logo.tsx +++ b/apps/engineeringblog/components/Logo/Logo.tsx @@ -1,4 +1,5 @@ -import { Link, Stack, SvgIcon } from "@mui/material"; +import { StyledLink as Link } from "@commons-ui/next"; +import { Stack, SvgIcon } from "@mui/material"; import { SxProps, Theme } from "@mui/material/styles"; import Image, { ImageProps } from "next/image"; import React from "react"; From 4f692fa939adb3fb84fb488dfde41865250fd026 Mon Sep 17 00:00:00 2001 From: Clemence Kyara Date: Fri, 6 Sep 2024 14:21:08 +0300 Subject: [PATCH 08/11] Fix TS issues --- apps/engineeringblog/components/Logo/Logo.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/engineeringblog/components/Logo/Logo.tsx b/apps/engineeringblog/components/Logo/Logo.tsx index 3e0786617..daf8d1b42 100644 --- a/apps/engineeringblog/components/Logo/Logo.tsx +++ b/apps/engineeringblog/components/Logo/Logo.tsx @@ -41,7 +41,7 @@ const Logo = React.forwardRef(function Logo( ({ + sx={(theme: Theme) => ({ "&>svg,&>img": { transition: theme.transitions.create(["opacity", "transform"]), }, @@ -57,14 +57,14 @@ const Logo = React.forwardRef(function Logo( > {title?.length ? ( ({ + sx={{ fill: { xs: "none" }, fontSize: 32, left: -24, opacity: 0, position: "absolute", right: 0, - })} + }} > @@ -87,7 +87,7 @@ const Logo = React.forwardRef(function Logo( textTransform="uppercase" typography="h4" underline="none" - sx={({ transitions, typography }) => ({ + sx={({ transitions, typography }: Theme) => ({ display: "flex", fontFamily: typography.fontFamilyMono, transition: transitions.create(["opacity", "transform"]), From 15379fa45e7f8e2896cb4b1ac1c8b340848e8948 Mon Sep 17 00:00:00 2001 From: Clemence Kyara Date: Fri, 6 Sep 2024 14:21:42 +0300 Subject: [PATCH 09/11] Update test snapshots --- .../CommunityPlatforms.snap.js | 2 +- .../DesktopNavBar/DesktopNavBar.snap.js | 2 +- .../src/components/Document/Document.snap.js | 2 +- .../src/components/Entity/Entity.snap.js | 12 ++++----- .../src/components/Error/Error.snap.js | 2 +- .../components/ErrorPage/ErrorPage.snap.js | 2 +- .../src/components/Footer/Footer.snap.js | 4 +-- .../src/components/NavBar/NavBar.snap.js | 4 +-- .../OpportunityCard/OpportunityCard.snap.js | 2 +- .../OrganisationImageLink.snap.js | 2 +- .../components/Repository/Repository.snap.js | 2 +- .../src/components/RichText/RichText.snap.js | 2 +- .../src/components/Tool/Tool.snap.js | 8 +++--- .../src/components/RichText/RichText.snap.js | 2 +- .../SocialMediaButton.snap.js | 2 +- .../components/OurMission/OurMission.snap.js | 26 +++++++++---------- .../src/components/Project/Project.snap.js | 2 +- .../ProjectPageHeader.snap.js | 2 +- .../src/components/RichText/RichText.snap.js | 2 +- .../SocialMediaButton.snap.js | 2 +- .../hurumap-next/src/Source/Source.snap.js | 2 +- 21 files changed, 43 insertions(+), 43 deletions(-) diff --git a/apps/charterafrica/src/components/CommunityPlatforms/CommunityPlatforms.snap.js b/apps/charterafrica/src/components/CommunityPlatforms/CommunityPlatforms.snap.js index 452a917f4..5d17634ac 100644 --- a/apps/charterafrica/src/components/CommunityPlatforms/CommunityPlatforms.snap.js +++ b/apps/charterafrica/src/components/CommunityPlatforms/CommunityPlatforms.snap.js @@ -65,7 +65,7 @@ exports[` renders unchanged 1`] = `
renders unchanged 1`] = ` class="MuiGrid-root MuiGrid-item css-13i4rnv-MuiGrid-root" > diff --git a/apps/charterafrica/src/components/Document/Document.snap.js b/apps/charterafrica/src/components/Document/Document.snap.js index fb16e2067..095794dce 100644 --- a/apps/charterafrica/src/components/Document/Document.snap.js +++ b/apps/charterafrica/src/components/Document/Document.snap.js @@ -41,7 +41,7 @@ exports[` renders unchanged 1`] = ` class="MuiGrid-root MuiGrid-container MuiGrid-item MuiGrid-direction-xs-[object Object] MuiGrid-grid-xs-12 MuiGrid-grid-md-4 css-19fdzmu-MuiGrid-root" > diff --git a/apps/charterafrica/src/components/Entity/Entity.snap.js b/apps/charterafrica/src/components/Entity/Entity.snap.js index ae1cc245f..61775d515 100644 --- a/apps/charterafrica/src/components/Entity/Entity.snap.js +++ b/apps/charterafrica/src/components/Entity/Entity.snap.js @@ -121,7 +121,7 @@ exports[` renders unchanged 1`] = ` class="MuiGrid-root MuiGrid-item css-13i4rnv-MuiGrid-root" > renders unchanged 1`] = ` class="MuiGrid-root MuiGrid-item css-13i4rnv-MuiGrid-root" > renders unchanged 1`] = ` class="MuiGrid-root MuiGrid-item css-13i4rnv-MuiGrid-root" > renders unchanged 1`] = ` class="MuiGrid-root MuiGrid-item MuiGrid-grid-xs-12 css-18qart5-MuiGrid-root" > renders unchanged 1`] = ` class="MuiGrid-root MuiGrid-item MuiGrid-grid-xs-12 css-18qart5-MuiGrid-root" > renders unchanged 1`] = ` class="MuiGrid-root MuiGrid-item MuiGrid-grid-xs-12 css-18qart5-MuiGrid-root" > renders unchanged 1`] = `

diff --git a/apps/charterafrica/src/components/ErrorPage/ErrorPage.snap.js b/apps/charterafrica/src/components/ErrorPage/ErrorPage.snap.js index 99ae84642..4244469e5 100644 --- a/apps/charterafrica/src/components/ErrorPage/ErrorPage.snap.js +++ b/apps/charterafrica/src/components/ErrorPage/ErrorPage.snap.js @@ -35,7 +35,7 @@ exports[` renders unchanged 1`] = `

diff --git a/apps/charterafrica/src/components/Footer/Footer.snap.js b/apps/charterafrica/src/components/Footer/Footer.snap.js index 9d127a68e..811707dc6 100644 --- a/apps/charterafrica/src/components/Footer/Footer.snap.js +++ b/apps/charterafrica/src/components/Footer/Footer.snap.js @@ -89,7 +89,7 @@ exports[`