You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
OK, it's a weird one, granted, but I'm at a loss... :/
Description
In Firefox, simply adding pace-js to the application causes Angular to never fire the ApplicationRef.isStable = true event. But, in Chrome, Edge, Brave, it fires like expected...
Reproduction
Install the Angular CLI
Create a new clean Angular app: ng new testapp
Add the following in app.component.ts:
constructor(appRef: ApplicationRef){appRef.isStable.pipe(tap((isStable)=>console.log('stable',isStable)),first((isStable)=>isStable),take(1)).subscribe(()=>{console.log('******** Application is stable **********');});}
Run ng serve and confirm the output (in Firefox)
[webpack-dev-server] Live Reloading enabled.
stable false
Angular is running in development mode. Call enableProdMode() to enable production mode.
stable true
******** Application is stable **********
Add pace-js to the appliation: run ng add pace-js
Modify angular.json to include the pace-js script:
"scripts": [
"node_modules/pace-js/pace.min.js"
]
Run ng serve again and confirm the output (in Firefox)
[webpack-dev-server] Live Reloading enabled.
stable false
Angular is running in development mode. Call enableProdMode() to enable production mode.
Problem: The application never become "stable"! In Chrome and Edge, the isStable = true "event" is fired as expected.
the application will never be stable if you start any kind of recurrent asynchronous task when the application starts (for example for a polling process, started with a setInterval, a setTimeout or using RxJS operators like interval);
I know the pace-js source code has setInterval and setTimeout in it, so it's probably related somehow, I don't know. Any ideas how to resolve this? And why only Firefox seems affected?
Tested with:
Angular v13.3.0
Firefox v105.0.1 (64-bit)
pace-js v1.2.4
The text was updated successfully, but these errors were encountered:
We've had reports of something that sounds very similar, with AngularJS and an older version of Pace
After seeing this and digging around in Pace.sources and seeing it was Pace.sources[3] that was just sitting at 20% I added eventLag: false to Pace.options and Firefox looks to be loading without issue now. Of course I now have to dig into what changing that might break..
Edit - setting lagThreshold looks like the optimal change #62 (comment)
@BlairMcClelland
Thanks for the information. I looked at the linked comment and tried to play with eventLag.lagTreshold. Adding this code to main.ts seems to work (though I have no idea about any possible side-effect of changing eventLag.lagThreshold).
declare var Pace: any;
Pace.options.eventLag.lagThreshold = 12;
Note:
Pace.options.eventLag.lagThreshold = 10; does NOT work
Pace.options.eventLag.lagThreshold = 11 works, but much slower than 12
Hi,
OK, it's a weird one, granted, but I'm at a loss... :/
Description
In Firefox, simply adding
pace-js
to the application causes Angular to never fire theApplicationRef.isStable = true
event. But, in Chrome, Edge, Brave, it fires like expected...Reproduction
ng new testapp
app.component.ts
:ng serve
and confirm the output (in Firefox)pace-js
to the appliation: runng add pace-js
angular.json
to include the pace-js script:ng serve
again and confirm the output (in Firefox)Problem: The application never become "stable"! In Chrome and Edge, the
isStable = true
"event" is fired as expected.The Angular doc about ApplicationRef says:
I know the
pace-js
source code hassetInterval
andsetTimeout
in it, so it's probably related somehow, I don't know. Any ideas how to resolve this? And why only Firefox seems affected?Tested with:
The text was updated successfully, but these errors were encountered: