Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class pace-done added to body multiple times #515

Open
matt-snider opened this issue Feb 25, 2021 · 8 comments
Open

Class pace-done added to body multiple times #515

matt-snider opened this issue Feb 25, 2021 · 8 comments

Comments

@matt-snider
Copy link

matt-snider commented Feb 25, 2021

Hi there,

Thanks for this great library! It looks great and works very well, although I am having one minor issue.

Recently I noticed that on each navigation or request, the pace-done class is being added to body and not properly cleared on the next run. This doesn't affect the functionality, but over time, many duplicate instances of this class accumulate.

screenshot-2021-02-25T11:30:43

The fact that no one else has reported this leads me to believe that I might be making a mistake, or there is some issue specific to my setup. But I guess we'll see if anyone else reports the same behaviour. I'm hoping that someone might have some idea what could be causing this.

Some information that might be helpful:

@wsteven24
Copy link

wsteven24 commented Aug 19, 2021

Same issue over here. I'm using v1.2.4
image

@michaelthedev
Copy link

Having the same issue also. Keeps adding unnecessary spaces too
image

@SlavaEgorov
Copy link

Same for me

@browniebraun
Copy link

There is a pipe within the search pattern to replace pace-done by class pace-running which should not be in.

Replace line 276:
document.body.className = document.body.className.replace(/(pace-done )|/, 'pace-running ');

by

document.body.className = document.body.className.replace(/(pace-done )/, 'pace-running ');

Afterwards it will stop that nasty misbehavior.

Regards
-Andi

@matt-snider
Copy link
Author

@browniebraun Would you like to open a PR with this change?

@michaelthedev
Copy link

Hi @matt-snider Could this be added to the next update please? It's still happening on the latest version (https://cdn.jsdelivr.net/npm/pace-js@latest/pace.min.js)

@CodeByZach
Copy link
Owner

Hi @michaelthedev! Have you submitted a PR?

@michaelthedev
Copy link

oh, i tagged the wrong person. I just created the PR (#547)

I wasn't able to apply the fix on the minified version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants