Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fence_vmware_soap has no connection timeout, results in filling up tmp directory #446

Open
thanasis2028 opened this issue Nov 1, 2021 · 0 comments

Comments

@thanasis2028
Copy link
Contributor

The resource agent fence_vmware_soap has no connection timeout when creating a suds Client and does not respect any of the --power-timeout --shell-timeout --login-timeout options.

This is important because when running under pacemaker and trying to contact a server that doesn't respond, the script will run until pacemaker forcibly kills it, which leaks the created python tmpdir (and will eventually fill up the disk).

It can be easily observed by setting up fence_vmware_soap in pacemaker and then blocking the server in iptables:

pcs stonith create stonith_vmware fence_vmware_soap ipaddr="${esxi_host_ip}" ....
iptables -A INPUT -j DROP -s "${esxi_host_ip}"

And the /tmp/ directory will slowly start filling up.

thanasis2028 added a commit to thanasis2028/fence-agents that referenced this issue Nov 1, 2021
oalbrigt pushed a commit that referenced this issue Nov 3, 2021
* fence_vmware_soap: Use --login-timeout option
* Set timeout to 60s when disable-timeouts is used

Fixes issue #446.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant