Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The fence agent API is documentation is highly incomplete #398

Open
sjvudp opened this issue Apr 6, 2021 · 1 comment
Open

The fence agent API is documentation is highly incomplete #398

sjvudp opened this issue Apr 6, 2021 · 1 comment
Assignees

Comments

@sjvudp
Copy link

sjvudp commented Apr 6, 2021

https://github.com/ClusterLabs/fence-agents/blob/master/doc/FenceAgentAPI.md is highly incomplete, i.e.: No-one is able to develop a fence agent using that information only.
For example stonith -n calls the agent with parameter getconfignames (found by stracing stonith).
When using stonith -m the parameters are getinfo-devdescr, getinfo-devid, and getinfo-xml.
None of those parameters is documented.

I also think that any fence agent should have a "not-really" (-n) option that prevents actually performing fencing operations.
Such would be very valuable when testing the parameter processing of the agent (once there is a tool like ocf-tester for fence agents).

@oalbrigt oalbrigt self-assigned this Apr 6, 2021
@oalbrigt
Copy link
Collaborator

#552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants