Enahnce pacemaker.c #136
Assignees
Labels
Comments
|
We have a long-standing project in pacemaker to move functionality from command line tools into libraries. Then the tools just wrap the library calls. I could start working on converting crm_ticket next if it would help here. |
|
Perfect. I think it would be much safer and reliable to call function(s) instead of |
clumens
added a commit
to clumens/booth
that referenced
this issue
Jun 25, 2024
The function itself is very simple. The rest of the work is in save_attributes, where it needs to understand both the libpacemaker XML result as well as the result of calling crm_ticket directly. It's still pretty simple, though - just digging around in the XML to set a node pointer correctly. Fixes ClusterLabs#136
clumens
added a commit
to clumens/booth
that referenced
this issue
Oct 1, 2024
The function itself is very simple. The rest of the work is in save_attributes, where it needs to understand both the libpacemaker XML result as well as the result of calling crm_ticket directly. It's still pretty simple, though - just digging around in the XML to set a node pointer correctly. Fixes ClusterLabs#136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
pacemaker.c is full of
popen/systemcalls. This are not very safe (escape of arguments, need to run shell, ...) and it would be better to useexecand proper redirection (so stderr are split and could be logged). Another possibility might be to use some library instead of callingcrm_ticket(if such library exists).The text was updated successfully, but these errors were encountered: