New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consts [COM branch] #3

Open

sudogauss opened this issue Jan 28, 2023 · 1 comment

sudogauss commented Jan 28, 2023

You can just call constants.py -> const.py (default naming).
Please more comments for your consts (NEC, N_NEC???)
Suggestion to use something like that [i for i in range(n)] and not range objects directly. Also why use tuples?
motor PID and wheels PID seems to be a misconception. To check with LL.
Generally inline comments are used for consts
Need more details on MIN_T_MS and MAX_T_MS (seems to be a misconception again)

Collaborator

EKnight-Blue commented Jan 28, 2023

does not change anything
fair point
pointless. Tuples are immutable, lists are mutable, by definition constants do not change
okay
misconception...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment