'cairo/cairo.h' file not found

[concatime]

When building bemenu (and sway too), I face this:

In file included from lib/renderers/wayland/wayland.c:2:
In file included from lib/renderers/wayland/wayland.h:9:
lib/renderers/cairo.h:8:10: fatal error: 'cairo/cairo.h' file not found
#include <cairo/cairo.h>
         ^~~~~~~~~~~~~~~
1 error generated.
In file included from lib/renderers/wayland/registry.c:1:
In file included from lib/renderers/wayland/wayland.h:9:
lib/renderers/cairo.h:8:10: fatal error: 'cairo/cairo.h' file not found
#include <cairo/cairo.h>
         ^~~~~~~~~~~~~~~
1 error generated.
In file included from lib/renderers/wayland/window.c:2:
In file included from lib/renderers/wayland/wayland.h:9:
lib/renderers/cairo.h:8:10: fatal error: 'cairo/cairo.h' file not found
#include <cairo/cairo.h>
         ^~~~~~~~~~~~~~~
1 error generated.

This issue happens because pkgconfig strips the cairo namespace.
Relevant part from/lib/pkgconfig/cairo.pc:

Cflags: -I${includedir}/cairo

You can verify by yourself from Archlinux’s package.

I don’t know if this behaviour is for keeping backward compatibility, or that cairo namespace is deprecated.

Two options:

1. Rename lib/renderers/cairo.h to lib/renderers/cairo_internal.h, and replace <cairo/cairo.h> by <cairo.h> from it, otherwise we would have two cairo.h in compiler’s search path and probably an issue.
2. Remove stripping from upstream cairo.

[concatime]

Should I open an issue in sway too? This way we can opt for a common solution.

[Cloudef]

I guess we should rename cairo.h to cairo_renderer.h or something and then use cairo.h, pretty weird the pc file has changed like that.

[concatime]

I faced this issue with swaybg too, so I’ve opened an issue upstream https://gitlab.freedesktop.org/cairo/cairo/-/issues/479 once for all. We will wait for their response before any action.

[psychon]

You can verify by yourself from Archlinux’s package.

Does anyone know what exactly causes this? I downloaded the Archlinux package and it installs cairo.h to /usr/include/cairo/cairo.h, so shouldn't #include <cairo/cairo.h> still work?

[Cloudef]

Seems like it was answered. While unfortunate, we aren't doing the cairo include the documented way so we should fix it. Most likely bemenu won't be the only project where this issue happens.

[Cloudef]

maybe fixed here ebd7338

[concatime]

@psychon Well, I didn’t install cairo to /usr, and expected, rightfully, that pkg-config --cflags cairo would be enough (which wasn’t)

so shouldn't #include <cairo/cairo.h> still work?

This is the issue. It should have not worked because that’s not how cairo is meant to be used.

[concatime]

I confirm it works. Thank you.

[Cloudef]

Thanks, I'll try to prepare new release soon including this fix.