Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 and Update command for GeoIP #222

Closed
BlaneyXYZ opened this issue Mar 31, 2014 · 5 comments
Closed

IPv6 and Update command for GeoIP #222

BlaneyXYZ opened this issue Mar 31, 2014 · 5 comments

Comments

@BlaneyXYZ
Copy link
Contributor

These would be nice :)

@DhashS
Copy link

DhashS commented May 8, 2014

do we have to stick with the legacy DB, or is it OK to use a 3rd party API? I'll whip one up if it's the latter

@BlaneyXYZ
Copy link
Contributor Author

Doesn't bother me

@DhashS
Copy link

DhashS commented May 10, 2014

all done. Take a look here [[edited]] do you have any complaints in functionality?
EDIT: new pull req link here, i had to move the libs into disabled stuff #280

@BlaneyXYZ
Copy link
Contributor Author

After some testing it seems to break if info is missing (like ISP) can something be implemented if a field is missing? I really am grateful for your help

@DhashS
Copy link

DhashS commented Jun 4, 2014

 if is_valid_ip(inp):
    info = json_resp.items()
    for iter in range(1,len(info) + 1):
        final_return += "\x02" + json_resp.key()[iter] + "\x02" + ": " + json_resp.values()[iter]
    return final_return

This should work out fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants