Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.seen doesn't work with some legal IRC characters #250

Open
oxagast opened this issue Oct 14, 2016 · 3 comments
Open

.seen doesn't work with some legal IRC characters #250

oxagast opened this issue Oct 14, 2016 · 3 comments

Comments

@oxagast
Copy link

oxagast commented Oct 14, 2016

The command .seen also doesn't work as intended with nicks that have various characters like "`" which are legal characters for an IRC name, however, Cloudbot will always say "I can't look up that name, it is impossible to use!"

For example:
.seen oxagast`
Won't work.

@ghost
Copy link

ghost commented Oct 28, 2016

I can't reproduce this issue, got any logs?

@oxagast
Copy link
Author

oxagast commented Oct 28, 2016

Not sure what version of CloudBot JARVIS is running, but here's a log:

*** Topic for #secnews: #secnews #worldnews #secsploits #slashdot #grouphug brought to you by phar. hundreds of RSS feeds 
          in realtime. idle and read.
*** Topic set by tux [] [Mon Apr 18 12:07:45 2016]
[Users #secnews]
*** @sid            Corey84        Guest3871_    munemunk3y    r0d3nt|P_      techdarko  
*** +duhh           cstine         h3ndr1k       myrkraverk    RDNt           ThePeePs   
*** +honey0         D0gm4          handler       nawcom        redstarx       thurmyt3   
*** +rudy           davidp         HappyLoaf     nighty_       riftman        tmcaffeine 
***  agrathwohl     det            HMHackMaster  nix-7         RoboHak        tux        
***  aMunster       DrCode         ips50         NullOverflow  rootCIMv2      ubuntor    
***  astrutt        droogie        JARVIS        Nycatelos     samureye       WebDawg    
***  BaalRaElDagon  Echelon        jester`       Nyxus         schrodinger    Zed        
***  barbanegra     Ethix          KutmasteR     opticaldiff   scubacuda      zero9zero  
***  Beaches        fearghal       l0pher__      oxagast       sm0ke          zyme       
***  Bookersa       freekevin      Liothen       qthr          snide         
***  circle         Gen0           lucky225      r0d3nt        Subcomandante 
***  core           goingtoheaven  molo          r0d3nt|F      sudokek       
*** Irssi: #secnews: Total of 75 nicks [1 ops, 0 halfops, 3 voices, 71 normal]
*** Channel #secnews created Thu Jan  7 04:22:29 2016
*** Irssi: Join to #secnews was synced in 1 secs
<oxagast> .seen jester` 
<JARVIS> (oxagast) I can't look up that name, its impossible to use!

@edwardslabs
Copy link
Member

This regex needs to be adjusted to include all legal IRC characters.

https://github.com/CloudBotIRC/CloudBot/blob/master/plugins/history.py#L97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants