Skip to content
This repository has been archived by the owner on Dec 3, 2023. It is now read-only.

A lot of stuff breaks command registration; it shouldn't #6

Open
4 tasks
Minion3665 opened this issue Feb 25, 2022 · 4 comments
Open
4 tasks

A lot of stuff breaks command registration; it shouldn't #6

Minion3665 opened this issue Feb 25, 2022 · 4 comments
Assignees
Labels
🐛 Bug This fixes a bug ✓ Feature This adds a new feature ✨ Quality of Life This adds a feature to make the user experience better ‼️ Urgent This is a change that must be applied now

Comments

@Minion3665
Copy link
Member

  • Commands without names
  • Commands without descriptions
  • Repeated commands (& repeated subcommands)
  • Commands with repeated arguments

We might want to rewrite the builder to automatically validate and also avoid the rather janky command builder syntax, although this will break full compatability with discord.js I think it could be worth it for nicer registration syntax & the same syntax across commands and subcommands. The old way of registering commands would still work, assuming you didn't use our 'registerCommandsIn' method (which we're hoping everyone will), but you wouldn't be able to use it in the file exports without writing your own handler.

We could also attempt to make both compatable, but this includes doing validation for both systems which is far less elegant and provides extra complexity to maintain, as well as the fact that permitting people to use either makes it much more likely that they'll use a mixture of both which, for obvious reasons, is not preferable.

@TheCodedProf, @PineaFan can you two weigh in on this please; do you like the djs command and subcommand builders or do you think I can do a better job?

@Minion3665 Minion3665 added ‼️ Urgent This is a change that must be applied now ✓ Feature This adds a new feature ✨ Quality of Life This adds a feature to make the user experience better 🐛 Bug This fixes a bug labels Feb 25, 2022
@Minion3665 Minion3665 added this to the Release Version 1 milestone Feb 25, 2022
@Minion3665
Copy link
Member Author

Minion3665 commented Feb 25, 2022

(Apologies also for the double ping; I accidentally created this over at clicksminuteper/nucleus#1 and had to delete it)

@PineaFan
Copy link
Member

I'm fine with your method, the d.js compatible one is a tad janky

@PineaFan
Copy link
Member

Option for adding files as multiple choice args of a command could also be helpful

Custom builder is also preferred for consistency

@Minion3665
Copy link
Member Author

Option for adding files as multiple choice args of a command could also be helpful

Custom builder is also preferred for consistency

+1 will build this then; we probably won't do our own checking on djs command builders, however if there's a single point where we can add checks to add them to both I may well add them there rather than earlier in the code

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 Bug This fixes a bug ✓ Feature This adds a new feature ✨ Quality of Life This adds a feature to make the user experience better ‼️ Urgent This is a change that must be applied now
Projects
None yet
Development

No branches or pull requests

3 participants