Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic reconnect ignores settings applied for the connection #371

Open
pet74alex opened this issue May 2, 2024 · 0 comments
Open

Automatic reconnect ignores settings applied for the connection #371

pet74alex opened this issue May 2, 2024 · 0 comments

Comments

@pet74alex
Copy link

pet74alex commented May 2, 2024

Client::Impl::RetryGuard performs automatic connection resets so the application code doesn't have a chance to restore expected connection settings applied before executing the current request.

For example, SET mutations_sync=2, automatic reconnect, ALTER TABLE sequence causes mutations to be executed asynchronously when the application assumes synchronous execution of the mutation.

It looks like connection settings should be stored in the Client::Impl and they should be re-applied in case of such reconnect before executing the client query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant