Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CertificateUtils should support the VoIP message #53

Open
qiitro opened this issue Mar 16, 2019 · 0 comments
Open

CertificateUtils should support the VoIP message #53

qiitro opened this issue Mar 16, 2019 · 0 comments

Comments

@qiitro
Copy link

qiitro commented Mar 16, 2019

the method CertificateUtils.validateCertificate does not support the APNs VoIP message

   ` if (!cn.toLowerCase(Locale.US).contains("push")) {
        throw new CertificateException("Not a push certificate - " + cn);
    }`

   ` if (production && cn.toLowerCase(Locale.US).contains("apple development ios push services")) {
        throw new CertificateEnvironmentMismatchException("Invalid environment for this certificate");
    } else if (!production && cn.toLowerCase(Locale.US).contains("apple production ios push services")) {
        throw new CertificateEnvironmentMismatchException("Invalid environment for this certificate");
    }`

it may contains "voip services", not just "push"

@thanhly thanhly mentioned this issue May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant