-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update main.cpp to add ADC filters to reduce noise on voltage and current sensor #106
Open
Jahnkeanater
wants to merge
8
commits into
ClemensElflein:main
Choose a base branch
from
Jahnkeanater:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an IIR filter with a weight of 90% to the battery voltage, charge voltage, and charging current to reduce the noise in the ADC measurements.
With the sample rate being only 10Hz I think a weight of 80% is probably better. |
GPIO23 is connected to the PS pin of the onboard RT6150B-33GQW, if it's LOW (default) it's in PFM mode for best efficiency, if it's HIGH it's in PWM mode for improved ripple but worse efficiency at light loads. PWM mode should improve the ADC noise.
GPIO23 is connected to the PS pin of the onboard RT6150B-33GQW, if it's LOW (default) it's in PFM mode for best efficiency, if it's HIGH it's in PWM mode for improved ripple but worse efficiency at light loads. PWM mode should improve the ADC noise.
Jahnkeanater
commented
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting the power supply into PWM mode by pulling GPIO23 High should also help improve the ADCs.
#75 Removing this since it might actually make the noise worse.
Jahnkeanater
changed the title
Update main.cpp to add ADC filters
Update main.cpp to add ADC filters and Putting the 3.3v power supply into PWM mode to reduce ripple
Aug 28, 2024
Looks like other people have already proved that PWM mode doesn't improve the noise.
Jahnkeanater
changed the title
Update main.cpp to add ADC filters and Putting the 3.3v power supply into PWM mode to reduce ripple
Update main.cpp to add ADC filters to reduce noise on voltage and current sensor
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an IIR filter with a weight of 90% to the battery voltage, charge voltage, and charging current to reduce the noise in the ADC measurements.