Add tests for /api/v1/accounts/:id/* 404 on deleted accounts

spec/controllers/api/v1/accounts/follower_accounts_controller_spec.rb

@@ -57,5 +57,30 @@
         expect([body_as_json[0][:id], body_as_json[1][:id]]).to contain_exactly(alice.id.to_s, bob.id.to_s)
       end
     end
+
+    context 'when request account is permanently deleted' do
+      before do
+        account.mark_deleted!
+        account.deletion_request.destroy
+      end
+
+      it 'returns http not found' do
+        get :index, params: { account_id: account.id, limit: 2 }
+
+        expect(response).to have_http_status(404)
+      end
+    end
+
+    context 'when request account is pending deletion' do
+      before do
+        account.mark_deleted!
+      end
+
+      it 'returns http not found' do
+        get :index, params: { account_id: account.id, limit: 2 }
+
+        expect(response).to have_http_status(404)
+      end
+    end
   end
 end

spec/controllers/api/v1/accounts/following_accounts_controller_spec.rb

@@ -57,5 +57,30 @@
         expect([body_as_json[0][:id], body_as_json[1][:id]]).to contain_exactly(alice.id.to_s, bob.id.to_s)
       end
     end
+
+    context 'when request account is permanently deleted' do
+      before do
+        account.mark_deleted!
+        account.deletion_request.destroy
+      end
+
+      it 'returns http not found' do
+        get :index, params: { account_id: account.id, limit: 2 }
+
+        expect(response).to have_http_status(404)
+      end
+    end
+
+    context 'when request account is pending deletion' do
+      before do
+        account.mark_deleted!
+      end
+
+      it 'returns http not found' do
+        get :index, params: { account_id: account.id, limit: 2 }
+
+        expect(response).to have_http_status(404)
+      end
+    end
   end
 end

spec/controllers/api/v1/accounts/lists_controller_spec.rb

@@ -21,5 +21,30 @@
       get :index, params: { account_id: account.id }
       expect(response).to have_http_status(200)
     end
+
+    context 'when request account is permanently deleted' do
+      before do
+        account.mark_deleted!
+        account.deletion_request.destroy
+      end
+
+      it 'returns http not found' do
+        get :index, params: { account_id: account.id }
+
+        expect(response).to have_http_status(404)
+      end
+    end
+
+    context 'when request account is pending deletion' do
+      before do
+        account.mark_deleted!
+      end
+
+      it 'returns http not found' do
+        get :index, params: { account_id: account.id }
+
+        expect(response).to have_http_status(404)
+      end
+    end
   end
 end

spec/controllers/api/v1/accounts/statuses_controller_spec.rb

@@ -95,5 +95,34 @@
         end
       end
     end
+
+    context 'when request account is permanently deleted' do
+      let(:account) { Fabricate(:account) }
+
+      before do
+        account.mark_deleted!
+        account.deletion_request.destroy
+      end
+
+      it 'returns http not found' do
+        get :index, params: { account_id: account.id, limit: 2 }
+
+        expect(response).to have_http_status(404)
+      end
+    end
+
+    context 'when request account is pending deletion' do
+      let(:account) { Fabricate(:account) }
+
+      before do
+        account.mark_deleted!
+      end
+
+      it 'returns http not found' do
+        get :index, params: { account_id: account.id, limit: 2 }
+
+        expect(response).to have_http_status(404)
+      end
+    end
   end
 end

spec/requests/api/v1/accounts_spec.rb

@@ -29,6 +29,31 @@
       end
     end
 
+    context 'when requesting a permanently deleted account' do
+      let(:other_account) { Fabricate(:account, deleted: true) }
+
+      before do
+        get "/api/v1/accounts/#{other_account.id}"
+      end
+
+      it 'returns http not found' do
+        expect(response).to have_http_status(404)
+      end
+    end
+
+    context 'when requesting an account pending deletion' do
+      let(:other_account) { Fabricate(:account) }
+
+      before do
+        other_account.mark_deleted!
+        get "/api/v1/accounts/#{other_account.id}"
+      end
+
+      it 'returns http not found' do
+        expect(response).to have_http_status(404)
+      end
+    end
+
     context 'when logged in' do
       subject do
         get "/api/v1/accounts/#{account.id}", headers: headers