Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added improved po_box handling #3

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

ellery
Copy link
Member

@ellery ellery commented Mar 5, 2018

No description provided.

@ellery ellery requested a review from seabre March 5, 2018 20:31
@ellery
Copy link
Member Author

ellery commented Mar 5, 2018

Before:

 StreetAddress::US.parse("PO Box 163, Alexandria, VA, 22303")
 => #<StreetAddress::US::Address:0x007ffad0b2a8e0 @unit_prefix="Box", @unit="163", @street="Alexandria", @redundant_street_type=true, @street_type=nil> 

after:

 StreetAddress::US.parse("PO Box 163 Alexandria VA 22303")
 => #<StreetAddress::US::Address:0x007f89d99ec1f8 @unit_prefix="Box", @unit="163", @city="Alexandria", @state="VA", @street="22303", @redundant_street_type=true, @street_type=nil> 

@seabre
Copy link
Member

seabre commented Mar 5, 2018

I mentioned this in slack, but If you're expecting that unit key value to be PO Box, the test should be testing for it to be PO Box it should fail until it's fixed. Context: https://crowdfiber.slack.com/archives/C4RMP4CJE/p1520285117000599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants