Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO Merge Soooooooooo Many Branches #1

Open
j-rewerts opened this issue Jan 19, 2019 · 6 comments
Open

TODO Merge Soooooooooo Many Branches #1

j-rewerts opened this issue Jan 19, 2019 · 6 comments
Assignees

Comments

@j-rewerts
Copy link
Contributor

@1Shad0w @Jdvdb @ngergel (plaid guy, super TA, awesome person) @sichunx10 @Kkill77 @dalidia @soomyy @Patel-rutvik @nhtnhan @hanjun1 @a-majeed @nyg1 @b-stolte @weilinnnnnn @jenrenema @bchelle @BenjWagg @ccchoi2 @LambaShell @jayng11

You thought you were done??? NEVER! For any of you that are interested in getting merged into master (so your changes show up on the site), I'm going to add some steps in this issue on how to submit a pull request.

@j-rewerts j-rewerts self-assigned this Jan 19, 2019
@j-rewerts
Copy link
Contributor Author

For those of you that think Git is confusing, don't worry. It is. It'll come with practise!

@j-rewerts
Copy link
Contributor Author

I'll be submitting a Pull Request from this branch, which was the branch that Noah and I made.

@j-rewerts
Copy link
Contributor Author

First off, switch to the branch you want to merge into master.
screen shot 2019-01-19 at 2 29 23 pm

@j-rewerts
Copy link
Contributor Author

GitHub will show something like this above the files.
screen shot 2019-01-19 at 2 31 10 pm
This tells us how many changes we're missing from the master branch, and how many changes we've added since branching off the master branch.

@j-rewerts
Copy link
Contributor Author

There's an important button on the right side of that last picture.
screen shot 2019-01-19 at 2 33 24 pm
Github's famous pull request!

This will create a pull request, which I will review before merging into master.

@j-rewerts
Copy link
Contributor Author

Then your super cool changes will make it on our super awesome site!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant