fix: add uuid validation at controller level #1660
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Issue Overview
This PR addresses #1659
Description
Currently when a string that isn't a UUID is passed into endpoints that take a UUID as a path parameter it gets all the way to the DB layer before an error is thrown. This is dangerous in that a malicious actor could pass in some nefarious string and get close to messing with the database or getting information from the database. We don't believe this could actually happen, but for an extra level of security this PR adds UUID validation at the controller level to stop these calls well before the DB
How Can This Be Tested/Reviewed?
http://localhost:3100/docs
.Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.