You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
We have some components that handle attribute values in non-standard ways.
For example, our <cod-button> component has data-disable which expects boolean value of true or false but should really conform to the HTML standard of boolean attributes.
Describe the solution you'd like
Generally speaking, we should update our component APIs to adhere to all HTML standard microsyntaxes. Specifically, the following microstandards are relevant to our components:
Also, unless the attribute is a boolean attribute, the component should treat attribute="undefined" or attribute="" the same as omitting the attribute entirely. In Storybook stories, we should prefer omitting the attribute entirely if the storybook control is not set.
This issue is to go through all components and update each attribute that resembles these microsyntaxes to adhere to the standard.
Work breakdown
It'll help us avoid merge conflicts if we break down the work this way per component. Components are distributed in this spreadsheet: https://is.gd/ETzUCF.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
We have some components that handle attribute values in non-standard ways.
For example, our
<cod-button>
component hasdata-disable
which expects boolean value oftrue
orfalse
but should really conform to the HTML standard of boolean attributes.Describe the solution you'd like
Generally speaking, we should update our component APIs to adhere to all HTML standard microsyntaxes. Specifically, the following microstandards are relevant to our components:
success
,danger
,primary
,secondary
, etc.)Also, unless the attribute is a boolean attribute, the component should treat
attribute="undefined"
orattribute=""
the same as omitting the attribute entirely. In Storybook stories, we should prefer omitting the attribute entirely if the storybook control is not set.This issue is to go through all components and update each attribute that resembles these microsyntaxes to adhere to the standard.
Work breakdown
It'll help us avoid merge conflicts if we break down the work this way per component. Components are distributed in this spreadsheet: https://is.gd/ETzUCF.
The text was updated successfully, but these errors were encountered: