-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new action buttons for redesign #154
Comments
@sreidthomas the button built in this PR is very similar to how we're going to want to implement this button: #158 The only difference is that we do not need to use a |
cc @jedgar1mx - I recommended here that we use attr instead of slots for the body text of the buttons. There are a few benefits to this:
EDIT: As discussed in standup, we'll move toward named slots for easier customization and styling in the future instead of using attributes for content or using nested custom elements. So we'll use two names slots for the 'title' and 'body' of the button. |
@sreidthomas for creating the circle beneath the icon, we're going to want to edit the icon component. In that component, we should add a boolean attribute named something like To implement the circle, we could take two possible approaches:
|
Adding circle beneath the icon
Approach 1: Use positioning and z-index
Approach 2: Using background-image
|
I am going to read over the documents you linked for Approach 1 but so far Approach 2 seems like it fits my skillset for now @maxatdetroit |
As far as button :hover effect, how about we have a (invisible) white border that turns light green. I'm using white border to avoid jumping button effect. However, light green bottom-border approach I meant to use on small screens only. It would be cool to animate the border to slowly encircle the button (I'll look for the example). |
Understanding Boolean Attributes
|
The Icon already has a container doesn't it @maxatdetroit:
|
Yes, we can try reusing the |
This was completed in #167 |
Describe the solution you'd like
As part of a redesign of detroitmi.gov, we'll be creating new action buttons.
This issue is to build a new component in the design system for the new action button.
The button should accept the following attributes:
icon
the name of the icon to be used on the buttonprimary-text
the text to be used in the primary style (i.e. the bold text)secondary-text
the text to be used in the secondary style (i.e. the thin text)The button should look like this:
Oftentimes, the buttons will be laid out in a grid so we have to make sure that layout looks good and the buttons are consistently sized and primary text is aligned.
Additional context
@bankovic and I still need to discuss how these are styled on hover. Also, this will supersede (at least partially) #100 .
The text was updated successfully, but these errors were encountered: