Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and implement POSTing comments to a specific comment on the API #268

Open
Rikuoja opened this issue Nov 1, 2017 · 5 comments
Open

Comments

@Rikuoja
Copy link
Contributor

Rikuoja commented Nov 1, 2017

Also, serialize all comments related to a comment inside the specific comment JSON in the API.

@sanesane
Copy link

Commenting child comments is not supported/allowed. "Single thread commenting"

@Rikuoja
Copy link
Contributor Author

Rikuoja commented Dec 12, 2017

Agreed.

@Rikuoja
Copy link
Contributor Author

Rikuoja commented Mar 8, 2018

This is probably doable by first adding the existing Commentable mixin as a superclass for a BaseComment, and then creating CommentComment subclass for BaseComment? Then, a comment could be POSTed to a comment just as well as to a section.

However, then we would require recursively counting all the subcomments of a comment when counting the comments belonging to a section; as the comments would not be directly linked to the section itself, but we want to keep the section total comment number up to date.

@Rikuoja
Copy link
Contributor Author

Rikuoja commented Mar 8, 2018

Also, we would have to limit commentability so that CommentComment may not have CommentComment as a parent, but only a SectionComment?

@Rikuoja
Copy link
Contributor Author

Rikuoja commented Mar 8, 2018

If you feel that the current Commentable mixin is not useful here, feel free to suggest a refactor, as the mixin is currently used only for Section but no other classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants