Fix #535 & #542 & #541 & #409 & #529 & #549 & #590 & #579 & #568 & #506 & #557 & #574 & #594 #592
Conversation
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #592 +/- ##
==========================================
- Coverage 24.96% 24.74% -0.23%
==========================================
Files 121 121
Lines 2471 2514 +43
Branches 420 433 +13
==========================================
+ Hits 617 622 +5
- Misses 1540 1566 +26
- Partials 314 326 +12
Continue to review full report at Codecov.
|
jonnetanninen
changed the title
jonnetanninen
changed the title
jonnetanninen
changed the title
jonnetanninen
changed the title
jonnetanninen
changed the title
jonnetanninen
changed the title
jonnetanninen
changed the title
jonnetanninen
changed the title
…of-Helsinki/kerrokantasi-ui into feature/small-improvements # Conflicts: # src/i18n/fi.json
jonnetanninen
changed the title
There was a problem hiding this comment.
A few small issues:
- The error message styling should be finalized (increase left marginal, use proper font, get rid of the progress bar)
- When entering a Hearing, the Hearing name is no longer shown on the page title; instead, the name of the Hearing page is still "Tervetuloa".
- The spinner when (re)loading comments should be rendered inside the Mielipiteet section, so that the Mielipiteet header itself (and the count that is known) is visible when the spinner is displayed. This is a visual indication of what is being loaded, i.e. the comments below the header.
|
Doned! |
| <LoadSpinner /> | ||
| </div> | ||
| )} | ||
| {showCommentList && !this.state.showLoader && |
There was a problem hiding this comment.
I am thinking here we actually shouldn't require !this.state.showLoader.
This is because we would like the comment list header and the order filter selection to be visible during loading of comments, so the user can see what is being fetched and in what order.
There was a problem hiding this comment.
Actually this does not seem to make a difference anyway as the old condition showCommentList will be false while fetching as the sectionComments is empty. I think this might be appropriate as showing the filter selector while fetching would allow the user to spam API calls by rapidly changing the filter...
| <h2> | ||
| <FormattedMessage id="comments" /> | ||
| <div className="commenticon"> | ||
| <Icon name="comment-o" /> {get(sectionComments, 'count') ? sectionComments.count : '0'} |
There was a problem hiding this comment.
Here, we shouldn't use sectionComments.count but, rather, section.n_comments. The former is zero when fetching, but the latter always contains the corrent count. Very seldom do we need sectionComments.count anywhere.
Solves multiple small issues: #535 & #542 & #541 & #409 & #529 & #549 & #590 & #579 & #568 & #506 & #557 & #574 & #594