Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer issue with copy_to_device API #89

Open
Tristou27 opened this issue Dec 28, 2021 · 1 comment
Open

Timer issue with copy_to_device API #89

Tristou27 opened this issue Dec 28, 2021 · 1 comment
Assignees

Comments

@Tristou27
Copy link

Hello,

I'm not sure this is the right place for that but I'll take the risk to ask.

I notice today after a few utilization of the device API copy_to_device that the function is waiting for the timer expiration to return instead of relying on the end of the copy itself. I mean, if we set a timer to 300sec (which is the default btw) and we run a copy, the function will return only after 300 seconds.

After a few investigation (but I may be mistaken), I think that this is due to the use of the Dialog here that have all its statement configured with "loop_continue=True". The Dialog is waiting indefinitely even if there is no longer questions from the device, and the function will return after the end of the timeout.

A quick fix I see is to check somehow if we got the prompt again, that should indicate that the copy operation is either finished or in error. Maybe by adding a dialog statement matching the router's prompt ? Or maybe there is another way?

What do you think?

@omehrabi
Copy link
Contributor

Hi,

I dont think so the copy will return when the download successful but we have made some modification to 22.1 for copy_from_device please upgrade to that and if you still see that issue please send a log here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants