Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Resource and Datasource for Host Path Selector (infraHPathS) (DCNE-156) #1244

Merged
merged 11 commits into from
Aug 20, 2024
Merged

Add Resource and Datasource for Host Path Selector (infraHPathS) (DCNE-156) #1244

merged 11 commits into from
Aug 20, 2024

Conversation

gmicol
Copy link
Collaborator

@gmicol gmicol commented Jun 27, 2024

Resolves #1235

@gmicol gmicol self-assigned this Jun 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 86 lines in your changes missing coverage. Please review.

Project coverage is 84.85%. Comparing base (45b1d80) to head (2648c5d).
Report is 1 commits behind head on master.

Files Patch % Lines
...provider/resource_aci_access_interface_override.go 87.61% 49 Missing and 29 partials ⚠️
...vider/data_source_aci_access_interface_override.go 94.36% 6 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1244      +/-   ##
==========================================
+ Coverage   84.76%   84.85%   +0.09%     
==========================================
  Files          93       95       +2     
  Lines       34218    34992     +774     
==========================================
+ Hits        29006    29694     +688     
- Misses       3881     3936      +55     
- Partials     1331     1362      +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmicol gmicol force-pushed the aci_infra_host_path_selector branch from 1b546ce to 2d41025 Compare July 2, 2024 20:55
@gmicol gmicol force-pushed the aci_infra_host_path_selector branch from 2d41025 to 1370511 Compare July 31, 2024 13:41
akinross
akinross previously requested changes Aug 1, 2024
View reviewed changes
docs/data-sources/access_interface_override.md Outdated Show resolved Hide resolved
docs/resources/access_interface_override.md Outdated Show resolved Hide resolved
docs/resources/access_interface_override.md Outdated Show resolved Hide resolved
docs/resources/access_interface_override.md Outdated Show resolved Hide resolved
gen/testvars/infraRsHPathAtt.yaml Outdated Show resolved Hide resolved
internal/provider/resource_aci_access_interface_override_test.go Outdated Show resolved Hide resolved
@gmicol gmicol requested a review from akinross August 2, 2024 17:53
@akinross
Copy link
Collaborator

akinross commented Aug 4, 2024 •
edited
Loading

CI failing please check generated code difference, needs rebase

@gmicol gmicol force-pushed the aci_infra_host_path_selector branch 3 times, most recently from 265532b to 2d7150a Compare August 6, 2024 14:25
shrsr
shrsr previously approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol and others added 8 commits August 9, 2024 19:20
@gmicol
[minor_change] Add Resource and Datasource for Host Path Selector (in…
aeef569 
…fraHPathS).
@gmicol
[ignore] Re generate files after rebase.
560d3c0
@gmicol
[ignore] Regenerate resource and resource_test for InfraHPathS.
1026a6a
@akinross @gmicol
[ignore] Cherry-pick Akini's modifications to migration and target_dn…
7b8e3c2 
… changes from his EPG migration PRs. Removed all EPG's related information from definitions.
@gmicol
[minor_change] Add resource and data source for relation_to_host_path…
d0c9425 
… (infraRsHPathAtt). Provide attribute to add access base group to host path selector.
@gmicol
[ignore] Fixed Documentation for target_dn not being displayed correc…
0f9e005 
…tly.
@gmicol
[ignore] Fix resource_test.go template for default_parent/no_parent f…
bcf1167 
…or t_dn children.
@gmicol
[ignore] Rename host_path_selector resource and datasource to access_…
c542acc 
…interface_override. Limit the max host path to 1 for access_interface_override.
@gmicol gmicol requested a review from shrsr August 9, 2024 23:42
@gmicol gmicol force-pushed the aci_infra_host_path_selector branch from 2d7150a to 96bb856 Compare August 9, 2024 23:53
@gmicol gmicol requested a review from sajagana August 13, 2024 17:41
samiib
samiib previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samiib samiib changed the title Add Resource and Datasource for Host Path Selector (infraHPathS) Add Resource and Datasource for Host Path Selector (infraHPathS) (DCNE-156) Aug 15, 2024
@gmicol gmicol dismissed stale reviews from shrsr and samiib via 91f4e04 August 15, 2024 11:56
@gmicol gmicol requested review from shrsr and samiib August 15, 2024 11:56
anvitha-jain
anvitha-jain previously approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmicol
[ignore] Fix resourceName set to singular when max class allowed set …
2648c5d 
…to one. Modify Logic for generating Rs class set to one max class allowed.
@gmicol gmicol dismissed stale reviews from samiib and anvitha-jain via 2648c5d August 16, 2024 13:36
@gmicol gmicol requested review from anvitha-jain and samiib August 16, 2024 13:36
samiib
samiib approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shrsr
shrsr approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot dismissed akinross’s stale review August 20, 2024 20:26

Checks are passing now

@lhercot lhercot merged commit 176a6cb into CiscoDevNet:master Aug 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samiib samiib samiib approved these changes

@sajagana sajagana sajagana approved these changes

@anvitha-jain anvitha-jain anvitha-jain approved these changes

@shrsr shrsr shrsr approved these changes

@lhercot lhercot lhercot approved these changes

@akinross akinross Awaiting requested review from akinross akinross is a code owner

Assignees

@gmicol gmicol

Labels
enhancement new-data-source new-resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: create resource and datasource to support interface profile overriding (infraHPathS) (DCNE-156)
8 participants
@gmicol @codecov-commenter @akinross @lhercot @shrsr @anvitha-jain @sajagana @samiib