Add Resource and Datasource for Netflow Exporter Policy (netflowExporterPol) (DCNE-154) #1242

gmicol · 2024-06-26T17:53:58Z

Resolves #1211

codecov-commenter · 2024-06-26T18:14:24Z

Codecov Report

Attention: Patch coverage is 91.58249% with 100 lines in your changes missing coverage. Please review.

Project coverage is 85.25%. Comparing base (9465913) to head (a60dbbc).

Files with missing lines	Patch %	Lines
...l/provider/resource_aci_netflow_exporter_policy.go	89.34%	49 Missing and 29 partials ⚠️
...rovider/data_source_aci_netflow_exporter_policy.go	94.04%	7 Missing and 3 partials ⚠️
internal/provider/resource_aci_application_epg.go	88.88%	6 Missing ⚠️
...l/provider/resource_aci_endpoint_security_group.go	81.81%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1242      +/-   ##
==========================================
+ Coverage   85.08%   85.25%   +0.17%     
==========================================
  Files         100      102       +2     
  Lines       36784    37812    +1028     
==========================================
+ Hits        31298    32238     +940     
- Misses       4062     4118      +56     
- Partials     1424     1456      +32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/data-sources/netflow_exporter_policy.md

docs/resources/netflow_exporter_policy.md

gen/generator.go

docs/resources/netflow_exporter_policy.md

internal/custom_types/fvRsConsIf_prio.go

gen/generator.go

gen/templates/resource.go.tmpl

internal/provider/data_source_aci_endpoint_security_group.go

internal/validators/intBetweenFromString.go

docs/data-sources/netflow_exporter_policy.md

gen/definitions/properties.yaml

samiib

Just some questions.

internal/custom_types/qosDppPol_violateMarkDscp.go

internal/provider/resource_aci_data_plane_policing_policy.go

gen/templates/custom_type.go.tmpl

shrsr

Can you run go generate and update the changes again?

…r policy.

…tom string type for DstPort atrribute in Netflow Exporter Policy.

…tring types for attributes that need sementic equality integration for their valid values.

…erate resources and datasources where customtypes is applied.

…typo for validators and customtypes. Modify templates to fit these new typos.

…rce.go template.

…parison.

…efinitions for fvRsPathAtt and fvRsNodeAtt.

…overwrites for NetflowExporterPol's attributes.

…templates. Add range of valid values in documentation for properties with customtype.

…tes.

…values in schema when customtype equivalent type is not a number.

…rly multi relationship target/classes for Rs children.

…alidator in documentation from scientific notation to integer.

… a default value.

samiib

LGTM

sajagana

LGTM!

akinross

LGTM

shrsr

LGTM

lhercot

LGTM

gmicol added enhancement new-data-source new-resource labels Jun 26, 2024

gmicol self-assigned this Jun 26, 2024

gmicol requested review from lhercot, shrsr, akinross, anvitha-jain, sajagana and samiib June 26, 2024 17:56

akinross requested changes Jun 28, 2024

View reviewed changes

gmicol force-pushed the aci_netflow_exporter_pol_updated branch from 7fa6460 to 205af18 Compare July 2, 2024 20:50

gmicol force-pushed the aci_netflow_exporter_pol_updated branch from 205af18 to 9e33a48 Compare July 10, 2024 17:54

gmicol force-pushed the aci_netflow_exporter_pol_updated branch from 1139496 to 1c02cf2 Compare July 24, 2024 22:41

gmicol requested a review from akinross July 24, 2024 22:43

akinross requested changes Jul 29, 2024

View reviewed changes

gmicol force-pushed the aci_netflow_exporter_pol_updated branch from 1c02cf2 to 1db291a Compare August 7, 2024 17:55

gmicol requested a review from akinross August 7, 2024 17:56

gmicol force-pushed the aci_netflow_exporter_pol_updated branch from 1db291a to 916650e Compare August 9, 2024 17:55

samiib changed the title ~~Add Resource and Datasource for Netflow Exporter Policy (netflowExporterPol)~~ Add Resource and Datasource for Netflow Exporter Policy (netflowExporterPol) (DCNE-154) Aug 15, 2024

gmicol force-pushed the aci_netflow_exporter_pol_updated branch from 0b1d0fc to 046562c Compare August 15, 2024 12:23

sajagana requested changes Aug 20, 2024

View reviewed changes

gmicol requested a review from sajagana August 20, 2024 17:43

gmicol force-pushed the aci_netflow_exporter_pol_updated branch from 0e8aba3 to 1966b4f Compare August 20, 2024 17:47

samiib requested changes Aug 20, 2024

View reviewed changes

internal/custom_types/qosDppPol_violateMarkDscp.go Show resolved Hide resolved

internal/provider/resource_aci_data_plane_policing_policy.go Show resolved Hide resolved

gen/templates/custom_type.go.tmpl Show resolved Hide resolved

gen/templates/custom_type.go.tmpl Show resolved Hide resolved

gmicol requested a review from samiib August 23, 2024 13:13

gmicol force-pushed the aci_netflow_exporter_pol_updated branch 2 times, most recently from 206ca0f to 0655196 Compare August 26, 2024 16:13

shrsr requested changes Aug 26, 2024

View reviewed changes

gmicol added 20 commits September 6, 2024 18:32

[ignore] Modify documentation and attributes name for netflow exporte…

d96c6da

…r policy.

[ignore] Udpate vendor files. Test files for custom validator and cus…

6850029

…tom string type for DstPort atrribute in Netflow Exporter Policy.

[ignore] Add a new template and Modify generator to generate custom s…

d9bf48a

…tring types for attributes that need sementic equality integration for their valid values.

[ignore] Add customtypes to resource and datasource templates. Re gen…

42c5c00

…erate resources and datasources where customtypes is applied.

[ignore] Optimize the generator for ValidValuesMap rendering. Change …

4ff6093

…typo for validators and customtypes. Modify templates to fit these new typos.

[ignore] Rebase and incorporate custom types to changes made to resou…

8a7cce1

…rce.go template.

[ignore] Modify inBetweenFromString validator from int to float64 com…

0f25c6c

…parison.

[ignore] Modify properties for fvDnsAttr.

ab5b5e3

[ignore] Remove encapsulation attribute from datasource_required in d…

a62c8db

…efinitions for fvRsPathAtt and fvRsNodeAtt.

[ignore] Add relations to EPG and VRF for NetflowExporterPol. Modify …

47c18cd

…overwrites for NetflowExporterPol's attributes.

[ignore] Add missing property in properties.yml

41242a0

[ignore] Make clearer conditions for the customtype in generator and …

d725126

…templates. Add range of valid values in documentation for properties with customtype.

[ignore] Add a test to check semantic equality for customtype attribu…

88a9ce8

…tes.

[ignore] go generate again.

24f9c69

[ignore] Modify customtypes documentation rendering. Add extra valid …

e8f913a

…values in schema when customtype equivalent type is not a number.

[ignore] Modify documentation for classes with customtype.

7c077ed

[ignore] Modify resource and datasource doc templates to render prope…

ed0233e

…rly multi relationship target/classes for Rs children.

[ignore] Modify representation of min and max values for customtype v…

ab0c926

…alidator in documentation from scientific notation to integer.

[ignore] Add target_dn overwrite for documentations and examples.

45a25a3

[ignore] Rename Netflow by NetFlow in every related documentations.

db9f364

gmicol force-pushed the aci_netflow_exporter_pol_updated branch from 84d75c4 to 3b537f5 Compare September 6, 2024 22:51

[ignore] Add an Optional section in datasource doc when parent_dn has…

a60dbbc

… a default value.

gmicol force-pushed the aci_netflow_exporter_pol_updated branch from 3b537f5 to a60dbbc Compare September 6, 2024 22:57

samiib approved these changes Sep 8, 2024

View reviewed changes

sajagana approved these changes Sep 9, 2024

View reviewed changes

akinross approved these changes Sep 9, 2024

View reviewed changes

shrsr approved these changes Sep 9, 2024

View reviewed changes

anvitha-jain approved these changes Sep 9, 2024

View reviewed changes

lhercot approved these changes Sep 10, 2024

View reviewed changes

lhercot merged commit f66657b into CiscoDevNet:master Sep 10, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Resource and Datasource for Netflow Exporter Policy (netflowExporterPol) (DCNE-154) #1242

Add Resource and Datasource for Netflow Exporter Policy (netflowExporterPol) (DCNE-154) #1242

gmicol commented Jun 26, 2024

codecov-commenter commented Jun 26, 2024 •

edited

Loading

samiib left a comment •

edited

Loading

shrsr left a comment

samiib left a comment

sajagana left a comment

akinross left a comment

shrsr left a comment

lhercot left a comment

Add Resource and Datasource for Netflow Exporter Policy (netflowExporterPol) (DCNE-154) #1242

Add Resource and Datasource for Netflow Exporter Policy (netflowExporterPol) (DCNE-154) #1242

Conversation

gmicol commented Jun 26, 2024

codecov-commenter commented Jun 26, 2024 • edited Loading

Codecov Report

samiib left a comment • edited Loading

Choose a reason for hiding this comment

shrsr left a comment

Choose a reason for hiding this comment

samiib left a comment

Choose a reason for hiding this comment

sajagana left a comment

Choose a reason for hiding this comment

akinross left a comment

Choose a reason for hiding this comment

shrsr left a comment

Choose a reason for hiding this comment

lhercot left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jun 26, 2024 •

edited

Loading

samiib left a comment •

edited

Loading