[minor_change] Add nd_rest as a new generic ND REST API module. (DCNE-242) #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmicol
added
enhancement
gmicol
requested review from
akinross,
anvitha-jain,
lhercot,
sajagana,
samiib and
shrsr
as code owners
github-actions
bot
changed the title
gmicol
changed the title
gmicol
force-pushed
the
nd_rest
branch
2 times, most recently
from
b5a4cdf to
1af8cb5
Compare
akinross
requested changes
Dec 17, 2024
plugins/modules/nd_rest.py
Outdated
| - cisco.nd.modules | ||
|
|
||
| notes: | ||
| - Some payloads are known not to be idempotent, so be careful when constructing payloads. |
There was a problem hiding this comment.
should we add link reference to nd api docs and or swagger reference?
There was a problem hiding this comment.
what do you mean here fo example?
There was a problem hiding this comment.
a reference that points to api documentation of ND like: https://developer.cisco.com/docs/nexus-dashboard/latest/api-reference/
samiib
requested changes
Dec 20, 2024
…and file as input for the module. Add new tests.
akinross
requested changes
Jan 13, 2025
| @@ -56,6 +56,33 @@ def sanitize_list(list_to_sanitize, keys=None, values=None, list_recursive=True, | |||
| return result | |||
|
|
|||
|
|
|||
| def sanitize(obj_to_sanitize, keys=None, values=None, recursive=True, remove_none_values=True): | |||
There was a problem hiding this comment.
is there a reason to copy the code in this function instead of wrapping the existing functions into this function?
| payload=content, | ||
| ) | ||
|
|
||
| method = nd.params.get("method").upper() |
There was a problem hiding this comment.
should we also allow for upper inputs?
| # Append previous state of the object | ||
| if method in ("PUT", "DELETE", "PATCH"): | ||
| nd.existing = nd.previous = sanitize(nd.query_obj(path, ignore_not_found_error=True), keys_to_sanitize) | ||
| if method != "GET": |
There was a problem hiding this comment.
what do we set for previous GET combination, just empty dict? or should we set the current value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107
Addition of a new module
nd_restto handle generic ND REST API requests.