Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aci_rest use_ssl is defaults to False #466

Closed
nurseandthenerd opened this issue Aug 10, 2023 · 5 comments · Fixed by #475
Closed

aci_rest use_ssl is defaults to False #466

nurseandthenerd opened this issue Aug 10, 2023 · 5 comments · Fixed by #475
Assignees
Labels
bug Something isn't working

Comments

@nurseandthenerd
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The Documentation states that the default for use_ssl is True. After the 2.7 update all of the jobs started using http and were failing (this was due to a firewall not necessarily the module). explicitly adding use_ssl key fixed the problem, however that contradicted the documentation. Also the documentation stated that

"If the value is not specified in the task, the value of environment variable ACI_USE_SSL will be used instead."

I also set that environmental variable and that didn't work either.

Affected Module Name(s):

aci_rest

APIC version and APIC Platform

5.2(7g) and on-prem.

Collection versions

  • cisco.aci 2.7.0

Output/ Error message

Connection failed for http://apic/api/node/class/fabricHIfPol.json?order-by=fabricHIfPol.dn. Request failed: ",

Expected Behavior

data was returned

Actual Behavior

playbook failed

Playbook tasks to Reproduce

  • name: get {{ apic_env.title() }} {{ api_call.display | default(api_call.name) }}
    cisco.aci.aci_rest:
    hostname: "{{ apic_address }}"
    username: "{{ apic_user }}"
    private_key: "{{ apic_key_path }}"
    certificate_name: "{{ apic_cert_name }}"
    validate_certs: no
    use_proxy: no
    method: get
    path: /api/node/class/{{ api_call.name }}.json?order-by={{ api_call.name }}.dn{%- if api_call.subtree is defined -%}&rsp-subtree={{ api_call.subtree }}{%- endif -%}
    register: response
    changed_when: False

Important Factoids

References

(https://docs.ansible.com/ansible/latest/collections/cisco/aci/aci_rest_module.html)

@nurseandthenerd nurseandthenerd added the bug Something isn't working label Aug 10, 2023
@akinross
Copy link
Collaborator

Hi @nurseandthenerd , thank you for raising this issue. Just to confirm are only experiencing this with aci_rest module?

@nurseandthenerd
Copy link
Author

Hi @nurseandthenerd , thank you for raising this issue. Just to confirm are only experiencing this with aci_rest module?

I haven't really tested the other modules. We mainly use this one for the most part.

@shrsr
Copy link
Collaborator

shrsr commented Aug 10, 2023

@nurseandthenerd and @akinross It affects all the modules because there's a bug in the code. We'll take care of this. Thanks.

@shrsr shrsr self-assigned this Aug 10, 2023
@dalamanster
Copy link

When do you expect the fix please? is it matter of days or weeks/more? Sorry for pushing - I just want to plan some things. If I should stay with 2.6 release. Thanks for your great work!

@shrsr
Copy link
Collaborator

shrsr commented Aug 16, 2023

@dalamanster I would say a little more than a couple of weeks including the release time. I'll see if we can expedite this.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants