chore: adding versioned directory(v0 and v1) #319
Conversation
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
| // const { activeCircuit } = toRefs(simulatorStore) | ||
| name = name || 'Untitled' | ||
| name = stripTags(name) | ||
| scopeList[id].name = name |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
| scope.backups[scope.backups.length - 1] !== backup | ||
| ) { | ||
| scope.backups.push(backup) | ||
| scope.history = [] |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
| ) { | ||
| scope.backups.push(backup) | ||
| scope.history = [] | ||
| scope.timeStamp = new Date().getTime() |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
| */ | ||
| function loadModule(data, scope) { | ||
| // Create circuit element | ||
| var obj = new modules[rectifyObjectType(data.objectType)]( |
Check failure
Code scanning / CodeQL
Unvalidated dynamic method call High
Since the Vue simulator isn't released yet, it might be better to use v0 as the pre-release version. |
|
Sounds good.
…________________________________
From: Aryann Dwivedi ***@***.***>
Sent: Wednesday, June 19, 2024 12:35:39 PM
To: CircuitVerse/cv-frontend-vue ***@***.***>
Cc: IMT2019518 Ruturaj Mohite ***@***.***>; Mention ***@***.***>
Subject: Re: [CircuitVerse/cv-frontend-vue] chore: adding versioned directory(v0 and v1) (PR #319)
Looks good! Do you think we should name it v1 v2 instead of v0 v1?
Since the Vue simulator isn't released yet, it might be better to use v0 as the pre-release version.
—
Reply to this email directly, view it on GitHub<#319 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AM3ZIZTL333RALKIW4GKKVTZIEUUHAVCNFSM6AAAAABJOPTOD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZXHEYDKOBSGY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Fixes #320
Describe the changes you have made in this PR -
Versioned Directory Addition
v0andv1) with their respectivesrcfolders.Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.