Wait and retry on fail and loop functionalities are causing to repeat transactions

[juanenrisley]

While creating and deploying a new Shared Wallet, the use of a loop wait inside the waitAndRetryOnFail method is causing an error when no more retries are left. Thus there is a fail and a retry on the target call. This 2 methods need to be separated from each other so the wait and retry on fails happens and then a loop for waiting is used.

I found the error while debugging shared wallet creation. There was an incorrect condition for waiting organization fundation in the loop method and the loop was throwing an error each time it was done waiting. So the waitAndRetryOnFail method was retrying on that error, even if it was not an error from circles-core. This caused that when I was trying to fund the shared wallet with 1CRC, I ended up funding with 3CRC because the method has a default retry value of 3 times and was executing the transaction more times than requested.

[louilinn]

This should be quite high priority but we shouldn't start it in parallel with too many other things. But its next in line.