Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

变量名拼写等问题反馈 #129

Open
KohChia opened this issue Nov 4, 2024 · 6 comments
Open

变量名拼写等问题反馈 #129

KohChia opened this issue Nov 4, 2024 · 6 comments

Comments

@KohChia
Copy link

KohChia commented Nov 4, 2024

看到 v1.1.3 更新日志中提到__YY_Thunks_Disable_Rreload_Dlls这个变量。其中的Preload写成Rreload,以为只是文字写错,看了一下代码里写的也是这个。如有可能希望下个版本更新时同步修正。

@KohChia
Copy link
Author

KohChia commented Nov 4, 2024

api-ms-win-core-file.hppReOpenFile的实现:

if (FILE_FLAG_OPEN_NO_RECALLSECURITY_SQOS_PRESENT & dwFlagsAndAttributes)
{
  SecurityQualityOfService.ImpersonationLevel = SECURITY_IMPERSONATION_LEVEL((dwFlagsAndAttributes >> 16) & 0x3);
  if (FILE_FLAG_OPEN_REQUIRING_OPLOCKSECURITY_CONTEXT_TRACKING & dwFlagsAndAttributes)
  {
    SecurityQualityOfService.ContextTrackingMode = TRUE;
  }
  else
  {
    SecurityQualityOfService.ContextTrackingMode = FALSE;
  }
  if (FILE_FLAG_FIRST_PIPE_INSTANCESECURITY_EFFECTIVE_ONLY & dwFlagsAndAttributes)
  {
    SecurityQualityOfService.EffectiveOnly = TRUE;
  }
  else
  {
    SecurityQualityOfService.EffectiveOnly = FALSE;
  }
}
else
{
  SecurityQualityOfService.ImpersonationLevel = SecurityImpersonation;
  SecurityQualityOfService.ContextTrackingMode = TRUE;
  SecurityQualityOfService.EffectiveOnly = TRUE;
}

这几个宏值相同,但意义不同。其中SECURITY_SQOS_PRESENT之前已经在CreateFile2中反馈过 (v1.0.1.23)。

@KohChia
Copy link
Author

KohChia commented Nov 4, 2024

api-ms-win-core-registry.hpp中:
RegDeleteKeyValue可直接转发到SHDeleteValue
RegSetKeyValue可直接转发到SHSetValue

@KohChia
Copy link
Author

KohChia commented Nov 4, 2024

crypt32.hpp中:
CryptProtectMemoryCryptUnprotectMemory实现中的函数指针变量名依然是_pfnProcessPrng未修正。

@KohChia KohChia changed the title 变量名拼写问题 变量名拼写等问题反馈 Nov 4, 2024
@mingkuang-Chuyu
Copy link
Collaborator

mingkuang-Chuyu commented Nov 5, 2024

谢谢,但是RegDeleteKeyEx并没有问题。因为Windows XP x64支持这个API,x86的话系统本身就是忽略这个参数的。

__YY_Thunks_Disable_Rreload_Dlls,这个变量的话不做更新,因为Release版本已经发布,一旦改名又将设计新老版本兼容性问题。变量名称拼写错误不算大问题,就先这样把。

ReOpenFile 这个我需要重现审查一下。

@KohChia
Copy link
Author

KohChia commented Nov 6, 2024

谢谢,但是RegDeleteKeyEx并没有问题。因为Windows XP x64支持这个API,x86的话系统本身就是忽略这个参数的。

__YY_Thunks_Disable_Rreload_Dlls,这个变量的话不做更新,因为Release版本已经发布,一旦改名又将设计新老版本兼容性问题。变量名称拼写错误不算大问题,就先这样把。

ReOpenFile 这个我需要重现审查一下。

失误,忘了32位XP的确不需要考虑注册表的视角问题。

@KohChia
Copy link
Author

KohChia commented Dec 3, 2024

上面说的几个问题,除了 RegDeleteKeyEx 和拼写错误之外,其他的好像尚未确认:

  • api-ms-win-core-file.hpp中:
    ReOpenFile中的几个宏
  • api-ms-win-core-registry.hpp中:
    RegDeleteKeyValue
    RegSetKeyValue
  • crypt32.hpp中:
    CryptProtectMemoryCryptUnprotectMemory的函数指针变量名为从其他地方复制过来的_pfnProcessPrng

另外反馈一个新的问题:

  • api-ms-win-core-file.hpp中:
    SetFilePointerEx在 Windows 2000 已经支持

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants