From 096596b200faeefdca7e27e2ef60113f908eafbe Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stef=C3=A1n=20J=C3=B6kull=20Sigur=C3=B0arson?=
 <stefanjokull@hotmail.com>
Date: Thu, 22 Feb 2024 12:51:32 +0000
Subject: [PATCH] Adding `messaging.rabbitmq.message.delivery_tag` to the list
 of RabbitMQ specific tags (#433)

Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
---
 .chloggen/433.yaml                    | 4 ++++
 docs/attributes-registry/messaging.md | 1 +
 docs/messaging/rabbitmq.md            | 1 +
 model/registry/messaging.yaml         | 7 +++++++
 model/trace/messaging.yaml            | 4 ++++
 5 files changed, 17 insertions(+)
 create mode 100644 .chloggen/433.yaml

diff --git a/.chloggen/433.yaml b/.chloggen/433.yaml
new file mode 100644
index 0000000000..0ca14de923
--- /dev/null
+++ b/.chloggen/433.yaml
@@ -0,0 +1,4 @@
+change_type: enhancement
+component: messaging
+note: Add `messaging.rabbitmq.message.delivery_tag`` to the list of RabbitMQ specific tags
+issues: [433]
diff --git a/docs/attributes-registry/messaging.md b/docs/attributes-registry/messaging.md
index 2ec5ad6c2d..e53250e0c4 100644
--- a/docs/attributes-registry/messaging.md
+++ b/docs/attributes-registry/messaging.md
@@ -106,6 +106,7 @@ size should be used.
 | Attribute  | Type | Description  | Examples  |
 |---|---|---|---|
 | `messaging.rabbitmq.destination.routing_key` | string | RabbitMQ message routing key. | `myKey` |
+| `messaging.rabbitmq.message.delivery_tag` | int | RabbitMQ message delivery tag | `123` |
 <!-- endsemconv -->
 
 ## RocketMQ Attributes
diff --git a/docs/messaging/rabbitmq.md b/docs/messaging/rabbitmq.md
index 1c762c4386..1c8f2ec8cc 100644
--- a/docs/messaging/rabbitmq.md
+++ b/docs/messaging/rabbitmq.md
@@ -21,6 +21,7 @@ In RabbitMQ, the destination is defined by an *exchange* and a *routing key*.
 | Attribute  | Type | Description  | Examples  | Requirement Level |
 |---|---|---|---|---|
 | [`messaging.rabbitmq.destination.routing_key`](../attributes-registry/messaging.md) | string | RabbitMQ message routing key. | `myKey` | Conditionally Required: If not empty. |
+| [`messaging.rabbitmq.message.delivery_tag`](../attributes-registry/messaging.md) | int | RabbitMQ message delivery tag | `123` | Conditionally Required: When available. |
 <!-- endsemconv -->
 
 [DocumentStatus]: https://github.com/open-telemetry/opentelemetry-specification/tree/v1.26.0/specification/document-status.md
diff --git a/model/registry/messaging.yaml b/model/registry/messaging.yaml
index 868df05065..33d2d2ac4f 100644
--- a/model/registry/messaging.yaml
+++ b/model/registry/messaging.yaml
@@ -156,6 +156,13 @@ groups:
           RabbitMQ message routing key.
         examples: 'myKey'
         tag: tech-specific-rabbitmq
+      - id: rabbitmq.message.delivery_tag
+        type: int
+        brief: >
+          RabbitMQ message delivery tag
+        examples: 123
+        tag: tech-specific-rabbitmq
+
       - id: rocketmq.client_group
         type: string
         brief: >
diff --git a/model/trace/messaging.yaml b/model/trace/messaging.yaml
index cc980de321..6252c0830b 100644
--- a/model/trace/messaging.yaml
+++ b/model/trace/messaging.yaml
@@ -102,6 +102,10 @@ groups:
         requirement_level:
           conditionally_required: If not empty.
         tag: tech-specific-rabbitmq
+      - ref: messaging.rabbitmq.message.delivery_tag
+        requirement_level:
+          conditionally_required: When available.
+        tag: tech-specific-rabbitmq
 
   - id: messaging.kafka
     type: attribute_group