Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to idle settlement overlay bug #141

Closed
ChrisNeedham24 opened this issue Sep 24, 2023 · 0 comments · Fixed by #144
Closed

Jump to idle settlement overlay bug #141

ChrisNeedham24 opened this issue Sep 24, 2023 · 0 comments · Fixed by #144
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ChrisNeedham24
Copy link
Owner

ChrisNeedham24 commented Sep 24, 2023

This bug crashes the game if it occurs - though it would happen rarely due to the circumstances in which it occurs.

Steps to reproduce:

  1. Ensure that you have an idle settlement, i.e. one without an ongoing construction, as well as a deployed unit.
  2. Select the deployed unit.
  3. Press the J key - you should see the settlement highlighted in red, but the unit overlay still displayed instead of the settlement overlay.
  4. At this point, you can exit the bug state by clicking anywhere apart from the settlement (though if you click on the settlement, the unit will somehow move into the same quad. However, to recreate the bug, we now need to press the TAB key.
  5. The settlement should still be highlighted, but the unit overlay should no longer be displayed. Under normal circumstances, we would expect the settlement overlay to be displayed.
  6. Lastly, click anywhere apart from the settlement itself - the game should crash.

The bug is due to the fact that the unit overlay isn't removed when pressing the J key when a unit is selected - you can reference how the TAB key is handled in game_input_handler.py to see how it should work.

@ChrisNeedham24 ChrisNeedham24 added bug Something isn't working good first issue Good for newcomers hacktoberfest Issues that are appropriate for new contributors labels Sep 24, 2023
@ChrisNeedham24 ChrisNeedham24 removed the hacktoberfest Issues that are appropriate for new contributors label Nov 1, 2023
@ChrisNeedham24 ChrisNeedham24 self-assigned this Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
1 participant