Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change constructor prototype to allow const pin arrays #42

Open
JM-FRANCE opened this issue Apr 8, 2022 · 0 comments
Open

change constructor prototype to allow const pin arrays #42

JM-FRANCE opened this issue Apr 8, 2022 · 0 comments

Comments

@JM-FRANCE
Copy link

It's annoying to not be able to declare the rows and cols pins or the keys as const without having a compile time warning.

Please change the constructor prototype to document the fact that you are not messing around with the arrays and thus they can be const.

please go for:

Keypad::Keypad(const char *userKeymap, const byte *row, const byte *col, byte numRows, byte numCols)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JM-FRANCE