Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KarmaForBeingAnnoyingMod not working for v55 #8

Open
JesseOosterwijk opened this issue Jul 25, 2024 · 9 comments
Open

KarmaForBeingAnnoyingMod not working for v55 #8

JesseOosterwijk opened this issue Jul 25, 2024 · 9 comments

Comments

@JesseOosterwijk
Copy link

JesseOosterwijk commented Jul 25, 2024

Hi,

I am not really familiar with mod writing in general, but it seems the current mod version is not working at the moment.
It seems to still use some old version maybe? As the "NoiseMakerPropItemActivatePacth" typo in the log which is activated when using an annoying item seems to not be in the plugin file anymore? As i said, not really familiar with C programming languages
Below you can see the stacktrace:

[Info :Chrigi.KarmaForBeingAnnoyingMod] NoiseMakerPropItemActivatePacth ACTIVATED BRUHHHHH: Clownhorn(Clone)
[Error : Unity Log] MissingMethodException: Method not found: void .Landmine.SpawnExplosion(UnityEngine.Vector3,bool,single,single)
Stack trace:
UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) (at :IL_0026)
UnityEngine.MonoBehaviour:StartCoroutine(IEnumerator)
KarmaForBeingAnnoying.Patches.NoisemakerPropPatch:NoiseMakerPropItemActivatePatch(PlayerControllerB&, NoisemakerProp&)
NoisemakerProp:DMDNoisemakerProp::ItemActivate(NoisemakerProp, Boolean, Boolean)
GrabbableObject:UseItemOnClient(Boolean)
GameNetcodeStuff.PlayerControllerB:DMD<GameNetcodeStuff.PlayerControllerB::ActivateItem_performed>(PlayerControllerB, CallbackContext)
UnityEngine.InputSystem.LowLevel.<>c__DisplayClass7_0:<set_onUpdate>b__0(NativeInputUpdateType, NativeInputEventBuffer*)
UnityEngineInternal.Input.NativeInputSystem:NotifyUpdate(NativeInputUpdateType, IntPtr)

[Info :Chrigi.KarmaForBeingAnnoyingMod] Karma
[Info :Chrigi.KarmaForBeingAnnoyingMod] NoiseMakerPropItemActivatePacth ACTIVATED BRUHHHHH: Clownhorn(Clone)
[Info :Chrigi.KarmaForBeingAnnoyingMod] NoiseMakerPropItemActivatePacth ACTIVATED BRUHHHHH: Clownhorn(Clone)

Karma seems to be applied correctly though :).
Let me know if I can help in any way o/

@patrickeller
Copy link

Same Problem here

@Chrigi2486
Copy link
Owner

Hey @JesseOosterwijk ,

Unfortunately we aren't developing these mods anymore due to uni workload, but feel free to fork the repo.

I'll make sure to look at and accept any merge requests and update the mod on Thunderstore.

If you'd like to take a shot at writing mods yourself, feel free to reach out and I can provide some guides that we used when we started.

Regards
Christian

@Toemmsen96
Copy link
Collaborator

Toemmsen96 commented Sep 13, 2024

Hi @JesseOosterwijk and @patrickeller

We both have not worked on Lethal Company mods in a while, but i want to check over this in the near future.
I have worked on this to some extent since release, but im not sure anymore if it would work on the new update and whatever. I may have time to check on this later today.
Sorry to not update this mod and not have written anything here in a while.
I would like to fix it soon, but can't really promise anything for now.

Best Regards
Tom

Edit:
As far as i remember were we working on a better way to kill a player as host, however we never really found that.

@Toemmsen96
Copy link
Collaborator

Toemmsen96 commented Sep 13, 2024

Can anyone give me a feedback if this works for them:
KarmaForBeingAnnoying.zip
(need to unpack it first and add it to the plugins folder)
@patrickeller @JesseOosterwijk

@JesseOosterwijk
Copy link
Author

I will try it out tonight probably; will post results here, thanks for the update!

@JesseOosterwijk
Copy link
Author

JesseOosterwijk commented Sep 16, 2024

I was bored at the office; so I tested it just now. Seems to work from first glance, will do some more testing with other objects and in multiplayer (Only tested clown horn for now)

@Toemmsen96
Copy link
Collaborator

I was bored at the office; so I tested it just now. Seems to work from first glance, will do some more testing with other objects and in multiplayer (Only tested clown horn for now)

ok thanks. I do think its not fully working yet and it still needs some ironing out but yeah, i will have to see when i have time to work on it more

@JesseOosterwijk
Copy link
Author

@Toemmsen96 Just let me know when you need me to test something, I also did not change the config file yet and tested with it.

Also, would you have some docs/resources on how to start with mods? Otherwise will look into it myself.

@Toemmsen96
Copy link
Collaborator

@Toemmsen96 Just let me know when you need me to test something, I also did not change the config file yet and tested with it.

Also, would you have some docs/resources on how to start with mods? Otherwise will look into it myself.

Ok thanks!
For getting into modding, i used this guide:
https://www.youtube.com/watch?v=4Q7Zp5K2ywI
https://github.com/LethalCompanyCommunity/LethalCompanyModdingWiki/wiki

I recommend using Visual Studio Community edition if you're on Windows and VS Code if you are on Linux.
Personally i use ILSpy for decompiling stuff, but DnSpy would also work.
Have fun getting into modding i guess, its not really that hard :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants