Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change resource.AddFile -> resource.AddWorkshop #94

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

charitea
Copy link
Contributor

This PR changes the resource.AddFile function to resource.AddWorkshop. Currently the .property files aren't downloaded for clients, and servers not using FastDL don't have clients download the logo file when using the resource.AddFile method, so resource.AddWorkshop allows for clients to get both the logo & .property files.

@Cherry
Copy link
Owner

Cherry commented Jul 20, 2024

Thank you for the PR! I've a few questions since I've been out of the gmod sphere for a while, so forgive any ignorance:

  • How does this work for folks that don't install the addon via the workshop, and say, customise the logo?
  • Or when in local development? Does this prevent the local files from being used, since it's now just pulling from the live workshop version?

@charitea
Copy link
Contributor Author

  • Currently, this would override any custom logo, but right now the logo isn't even being loaded anyway.
  • Local files override what's being pulled from the workshop.

Copy link
Owner

@Cherry Cherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Cherry Cherry merged commit 6dcace2 into Cherry:main Aug 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants