From 8dfcf86ec42fd9f9ab1aed96adb7c0b16c60a11d Mon Sep 17 00:00:00 2001
From: sjgllgh <129264181+sjgllgh@users.noreply.github.com>
Date: Fri, 8 Sep 2023 14:37:01 +0800
Subject: [PATCH] #4900 Fix linkismanager allocation ECM error logic, adjust
 resource allocation logic from large to small (#4901)

Co-authored-by: weipengfei <weipengfei@psbc.com>
---
 .../manager/am/selector/rule/ResourceNodeSelectRule.java      | 4 ++--
 .../linkis/manager/am/selector/rule/ScoreNodeSelectRule.java  | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/linkis-computation-governance/linkis-manager/linkis-application-manager/src/main/java/org/apache/linkis/manager/am/selector/rule/ResourceNodeSelectRule.java b/linkis-computation-governance/linkis-manager/linkis-application-manager/src/main/java/org/apache/linkis/manager/am/selector/rule/ResourceNodeSelectRule.java
index 200794671a..8e86f6906a 100644
--- a/linkis-computation-governance/linkis-manager/linkis-application-manager/src/main/java/org/apache/linkis/manager/am/selector/rule/ResourceNodeSelectRule.java
+++ b/linkis-computation-governance/linkis-manager/linkis-application-manager/src/main/java/org/apache/linkis/manager/am/selector/rule/ResourceNodeSelectRule.java
@@ -67,9 +67,9 @@ private Comparator<Node> sortByResource() {
                 .getNodeResource()
                 .getLeftResource()
                 .moreThan(nodeBRm.getNodeResource().getLeftResource())) {
-              return 1;
-            } else {
               return -1;
+            } else {
+              return 1;
             }
           }
         } catch (Throwable t) {
diff --git a/linkis-computation-governance/linkis-manager/linkis-application-manager/src/main/java/org/apache/linkis/manager/am/selector/rule/ScoreNodeSelectRule.java b/linkis-computation-governance/linkis-manager/linkis-application-manager/src/main/java/org/apache/linkis/manager/am/selector/rule/ScoreNodeSelectRule.java
index 43bf789d09..dae02bec5b 100644
--- a/linkis-computation-governance/linkis-manager/linkis-application-manager/src/main/java/org/apache/linkis/manager/am/selector/rule/ScoreNodeSelectRule.java
+++ b/linkis-computation-governance/linkis-manager/linkis-application-manager/src/main/java/org/apache/linkis/manager/am/selector/rule/ScoreNodeSelectRule.java
@@ -55,13 +55,13 @@ private Comparator<Node> sortByScore() {
         ScoreServiceInstance instanceB = (ScoreServiceInstance) nodeB;
         try {
           if (instanceA.getScore() > instanceB.getScore()) {
-            return 1;
+            return -1;
           }
         } catch (Exception e) {
           logger.warn("Failed to Compare resource ", e);
           return -1;
         }
-        return -1;
+        return 1;
       } else {
         return -1;
       }