Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unmaintained yaml library with a new one #203

Open
baruchiro opened this issue Feb 14, 2024 · 1 comment
Open

Replace unmaintained yaml library with a new one #203

baruchiro opened this issue Feb 14, 2024 · 1 comment
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers

Comments

@baruchiro
Copy link
Contributor

baruchiro commented Feb 14, 2024 •
edited
Loading

We are using an old yaml parsing package, which, for example, doesn't support omitempty.

https://github.com/Checkmarx/2ms/blob/master/reporting/yaml.go#L7-L14

I want to replace it with one of the newer packages:

Please discuss here which package you suggest, and after my approval, replace the current go-yaml/yaml with the newly selected package.
@baruchiro baruchiro added good first issue Good for newcomers dependencies Pull requests that update a dependency file labels Feb 14, 2024
@kaplanlior
Copy link
Contributor

Also consider upgrading to v3 of the existing library.
(It's newer by 2 years... although not active since)

baruchiro pushed a commit that referenced this issue Feb 15, 2024
use go-yaml/yaml v3
187adf7 
For #203

(cherry picked from commit c62ba5e)
baruchiro pushed a commit that referenced this issue Feb 15, 2024
use go-yaml/yaml v3
c62ba5e 
For #203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaplanlior @baruchiro